Skip to content

Robustify division in scattering ray C++ code. Adds test for nan in RT.#436

Merged
fakufaku merged 4 commits into
masterfrom
fix/issue433followup
May 1, 2026
Merged

Robustify division in scattering ray C++ code. Adds test for nan in RT.#436
fakufaku merged 4 commits into
masterfrom
fix/issue433followup

Conversation

@fakufaku

@fakufaku fakufaku commented May 1, 2026

Copy link
Copy Markdown
Collaborator

Adds example code of #433 as test.

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

@fakufaku fakufaku merged commit 4ede7df into master May 1, 2026
10 checks passed
@fakufaku fakufaku deleted the fix/issue433followup branch May 1, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant