Skip to content

Removes deprecated absorption param#430

Closed
fakufaku wants to merge 11 commits into
masterfrom
fix/remove_absorption_param
Closed

Removes deprecated absorption param#430
fakufaku wants to merge 11 commits into
masterfrom
fix/remove_absorption_param

Conversation

@fakufaku

@fakufaku fakufaku commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

This PR removes the deprecated absorption parameter from various methods in Room and ShoeBox.

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

fakufaku added 11 commits April 2, 2026 23:52
@fakufaku
Allows to provide normalized frequency to measured directivity plotti…
2c68f1d 
…ng function.
@fakufaku
Workaround for num_channels > 128 in resampling with samplerate.
18d3f45
@fakufaku
lint
bfd9173
@fakufaku
* Modernizes the build system to use cmake. CMake handles dependencie…
32d8412 
…s via FetchContent in ./external.

* Moves to setuptools-scm to handle version number tracking.
* Moving package management to pyproject.toml.
@fakufaku
Moving tests out of the main package.
a2b1d19
@fakufaku
Updates the CI to use cibuildwheel to build wheels for different arch…
d651b34 
…itectures.
@fakufaku
Updates the doc in CONTRIBUTING.rst for the new compile system. Adds …
42a0489 
…doc, repo, issues links in pyproject.toml. CHANGELOG.
@fakufaku
Removes the deprecated parameter from ShoeBox, Room.from_corners, and…
1da627d 
… Room.extrude.
@fakufaku
merge
967216b
@fakufaku
Merge branch 'master' into fix/remove_absorption_param
29d5433
@fakufaku
CHANGELOG
fd0f211
@fakufaku fakufaku closed this Apr 6, 2026
@fakufaku fakufaku deleted the fix/remove_absorption_param branch April 6, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fakufaku