Skip to content

Erik/harmonicscomments#427

Merged
fakufaku merged 4 commits into
LCAV:masterfrom
je-fleischhauer:erik/harmonicscomments
Feb 16, 2026
Merged

Erik/harmonicscomments#427
fakufaku merged 4 commits into
LCAV:masterfrom
je-fleischhauer:erik/harmonicscomments

Conversation

@je-fleischhauer

Copy link
Copy Markdown
Contributor

This merge request builds upon #422 .

  • My previous comments were a bit sloppy. I have revised the comments on the module. (But there is still room for improvement!)
  • I adapted the unit test to increase the code coverage.
  • I corrected a slip between order and degree of spherical harmonics.
  • I added some checks to make the code more robust.

@fakufaku fakufaku left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! I just found a couple typos in the docstrings. It would be great if you can fix them, and then I can merge it.

Comment thread pyroomacoustics/directivities/harmonics.py Outdated
Comment thread pyroomacoustics/directivities/harmonics.py Outdated
@fakufaku

Copy link
Copy Markdown
Collaborator

Thank you so much, this is great!

@fakufaku fakufaku merged commit 4cb001f into LCAV:master Feb 16, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants