Skip to content

Fix octave band filters and their bandwidths#424

Merged
fakufaku merged 10 commits into
masterfrom
fix/rt_octave_bands
Jan 25, 2026
Merged

Fix octave band filters and their bandwidths#424
fakufaku merged 10 commits into
masterfrom
fix/rt_octave_bands

Conversation

@fakufaku

@fakufaku fakufaku commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes several problems I noticed.

  1. The lowest octave band filter was malformed when using "octave_bands_keep_dc=True".
  2. The bandwidth of the octave bands were not correct for the lowest and high bands.
  3. Refactor the way the RIR is weighted with the histogram in simulation/rt.py.
  4. Adds a test that compares the energy decay of ISM vs RT.
  5. Improves the implementation of the RT60 measurement function.
  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

@fakufaku fakufaku changed the title Fix octave band processing of ray tracing RIR Fix octave band filters and their bandwidths Jan 25, 2026
@fakufaku fakufaku merged commit 9e6d697 into master Jan 25, 2026
48 checks passed
@fakufaku fakufaku deleted the fix/rt_octave_bands branch January 25, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant