Skip to content

Fixes extra 40 samples delay with measured directivities (issue #398).#400

Merged
fakufaku merged 4 commits into
masterfrom
fix/issue-398
May 18, 2025
Merged

Fixes extra 40 samples delay with measured directivities (issue #398).#400
fakufaku merged 4 commits into
masterfrom
fix/issue-398

Conversation

@fakufaku

Copy link
Copy Markdown
Collaborator

With analytical directivity, the fractional delay of the echoes are computed as analytical filter, which necessitates manually adding a global delay so that the fractional delay impulse response fits in the RIR.
With measured directivities, the fractional delays are applied by convolution and naturally contain the global delay.
The global delay was applied to the echo time of arrival in both cases, which resulted in the delay being applied twice for measured directivities.

This fix avoids applying the manual delay when using measured directivities.

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

Happy PR 😃

@fakufaku fakufaku merged commit 5d53aff into master May 18, 2025
20 of 38 checks passed
@fakufaku fakufaku deleted the fix/issue-398 branch March 16, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant