Skip to content

Develop#94

Merged
PascalUlor merged 205 commits into
masterfrom
develop
Feb 6, 2020
Merged

Develop#94
PascalUlor merged 205 commits into
masterfrom
develop

Conversation

@PascalUlor

Copy link
Copy Markdown
Contributor

What does this PR do?

Deploy RC3 changes to production

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works .
  • New and existing unit tests pass locally with my changes

Screenshots (if appropriate)

Questions:

vebradev and others added 24 commits February 5, 2020 19:18
Removes outline on focus from input, text area & select elements.
Fixes judge avatar issue on Firefox.
Changes spinner color to match logo color.
add history redirect to login page on signout
yield handle errors in user sagas to log error message to users
address some of ayomides findings
yield all handleerror function calls in all sagas
make display images inline-block
add side nav to addteam, addparticiapant and create team components
re-implement ayomides fix for mobile responsiveness on userprofile
@ghost

ghost commented Feb 6, 2020

Copy link
Copy Markdown

DeepCode's analysis on #48c132 found:

  • 0 critical issues. ⚠️ 0 warnings and 5 minor issues. ✔️ 2 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@attaradev attaradev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it...

@PascalUlor PascalUlor merged commit 03b751c into master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants