Skip to content

[Release] WASM Shim v0.14.1#385

Merged
adam-cattermole merged 2 commits into
release-0.14from
release-0.14.1
Jun 26, 2026
Merged

[Release] WASM Shim v0.14.1#385
adam-cattermole merged 2 commits into
release-0.14from
release-0.14.1

Conversation

@adam-cattermole

Copy link
Copy Markdown
Member

No description provided.

alexsnaps and others added 2 commits June 25, 2026 21:23
Signed-off-by: Adam Cattermole <a.d.cattermole@gmail.com>
@adam-cattermole adam-cattermole self-assigned this Jun 25, 2026
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 86de429f-bd3c-4fc3-81b7-dc8938807eb0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release-0.14.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thomasmaas

Copy link
Copy Markdown
Contributor

Wondering if this change will bite us

@adam-cattermole

Copy link
Copy Markdown
Member Author

Wondering if proxy-wasm/proxy-wasm-rust-sdk#305 will bite us

Could you elaborate @thomasmaas?

@thomasmaas

thomasmaas commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

If there is any logic in authorino or limitador that depends on not differentiating between between missing and empty headers?

@adam-cattermole

adam-cattermole commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

If there is any logic in authorino or limitador that depends on not differentiating between between missing and empty headers?

I'm not sure I'm following. As far as I can tell the only use of the get_map_value is from here, and we correctly validate None as not present/not a gRPC content-type:

wasm-shim/src/data/cel.rs

Lines 333 to 337 in 7d59d53

let content_type = req_ctx.get_request_header("content-type");
if !content_type.as_deref().is_some_and(is_grpc_content_type) {
return None;
}

For our other header access we leverage get_map which already allows/supports headers with empty values

@adam-cattermole adam-cattermole merged commit ed79f35 into release-0.14 Jun 26, 2026
17 checks passed
@adam-cattermole adam-cattermole deleted the release-0.14.1 branch June 26, 2026 08:26
@github-project-automation github-project-automation Bot moved this to Done in Kuadrant Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants