fix: preserve split-form (--flag value) user-managed broker-router co…

[rogueslasher]

What does this PR do?

Fixes the broker-router command reconciliation logic to correctly handle user-managedflags written in split form (--flag value) instead of only --flag=value.Previously mergeCommand dropped the value token of such flags on reconcile, and
filterManagedFlags could report false drift for the orphaned value token.

Details

internal/controller/broker_router.go:

• Added commandEntry / parseCommandEntries to split a container command into logical entries (binary name, --flag=value, --flag value pair, or bare --flag).
• Rewrote filterManagedFlags and mergeCommand to operate on these logical entries instead of raw argv tokens, so split-form flags and their valuesare preserved/compared as a unit.
• Switched managed-flag matching from strings.HasPrefix to an exact matchon the flag name (extracted before =), avoiding accidental prefixcollisions. All existing managed flags are not prefixes of one another, soexisting behavior is unchanged.

internal/controller/deployment_test.go:

• TestFilterManagedFlags: added cases for a user split-form flag (stripped)and a managed split-form flag (kept as a unit).
• TestMergeCommand: added cases for preserving user split-form flags, mixedmanaged =-form + user split-form flags, and a managed split-form flagbeing replaced by the desired =-form value.
• TestDeploymentNeedsUpdate: added a no-op case for a user-managedsplit-form flag (previously reported false drift).

Summary by CodeRabbit

• Refactor

  • Improved command-parsing to treat command tokens as flag entries, correctly handling both --flag=value and split --flag value forms; preserves binary name and groups flag/value pairs.

• Tests

  • Added coverage ensuring user split-form flags are preserved/ignored as intended and managed flags are merged or replaced correctly across mixed scenarios.

[coderabbitai]

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8efb457c-dcb7-447f-9ba0-34b89aa7553b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[rogueslasher]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.