docs(auth): add initial SEP-991 impact assessment#1066
Conversation
Signed-off-by: Aditya7880900936 <adityasanskarsrivastav788@gmail.com>
📝 WalkthroughWalkthroughNew design document assessing SEP-991's impact on MCP Gateway authentication. Covers current DCR-based assumptions, CIMD shift mechanics, documentation alignment needs, Keycloak compatibility questions, and recommended investigation directions. ChangesSEP-991 Impact Assessment
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @Aditya7880900936, thanks for putting this together. A couple of things: First, could you update the PR description to remove "Fixes #396"? The investigation and design doc for that issue still has more ground to cover (the follow-up items you listed here, for example), so we would want to keep the issue open. Second, are you planning to continue progressing this investigation further, or would you prefer to land what is here and leave the remaining work for someone else to pick up? Either way is fine, just want to understand your intent so we can plan accordingly. |
|
Hi @david-martin, Thanks for the review. I've updated the PR description and removed the issue-closing reference. Yes, I'd like to continue working on this investigation. My intention with this PR was to capture the initial findings and establish a starting point for the discussion. I'd appreciate any guidance on the preferred next steps. In particular, if there are specific areas you'd like me to focus on next, or any recommendations on how you'd like the remaining investigation to be approached, I'd be happy to continue contributing. |
Summary
Adds an initial investigation document for issue #396 to assess the impact of SEP-991 (OAuth Client ID Metadata Documents) on MCP Gateway authentication flows, examples, and documentation.
Findings
Follow-up Investigation
Related to #396
Summary by CodeRabbit