Skip to content

Upgrade Go to 1.26.3#262

Open
thomasmaas wants to merge 2 commits into
mainfrom
upgrade-go-1.26.3
Open

Upgrade Go to 1.26.3#262
thomasmaas wants to merge 2 commits into
mainfrom
upgrade-go-1.26.3

Conversation

@thomasmaas

@thomasmaas thomasmaas commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Upgrade Go from 1.25.9 to 1.26.3.

Changes:

  • go.mod: go 1.25.9go 1.26.3
  • Dockerfile: mirror.gcr.io/library/golang:1.25mirror.gcr.io/library/golang:1.26

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain version from 1.25 to 1.26 in project documentation, Docker build configuration, and Go module settings.

Signed-off-by: Thomas Maas <thomas@webtypes.com>
@thomasmaas thomasmaas added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Bumps the Go version from 1.25 to 1.26 in three places: the go directive in go.mod is updated from 1.25.9 to 1.26.3, the Docker builder stage base image is updated from golang:1.25 to golang:1.26, and the CLAUDE.md documentation is updated to reference Go 1.26+.

Changes

Go 1.26 Version Bump

Layer / File(s) Summary
Go 1.26 version update across module, Docker, and docs
go.mod, Dockerfile, CLAUDE.md
go.mod directive bumped from 1.25.9 to 1.26.3, Dockerfile builder stage base image updated from golang:1.25 to golang:1.26, and CLAUDE.md updated to reflect Go 1.26+ as the minimum requirement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A version bump, small but true,
From twenty-five to twenty-six it grew!
The module, the Docker, the docs all say,
Go 1.26 is here to stay.
Hippity-hop, the toolchain's new! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Upgrade Go to 1.26.3' directly and accurately summarises the primary change across all modified files (go.mod, Dockerfile, and CLAUDE.md).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-go-1.26.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

codecov-commenter commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.86%. Comparing base (08bb9bc) to head (77e55d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   77.89%   75.86%   -2.04%     
==========================================
  Files          18       18              
  Lines        1131     1131              
==========================================
- Hits          881      858      -23     
- Misses        202      217      +15     
- Partials       48       56       +8     
Flag Coverage Δ
integration 71.52% <ø> (-2.22%) ⬇️
unit 47.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1alpha1 (u) 91.48% <ø> (ø)
pkg/helpers (u) 80.95% <ø> (ø)
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) 63.12% <ø> (-1.42%) ⬇️
pkg/limitador (u) 98.27% <ø> (ø)
controllers (i) 70.02% <ø> (-6.06%) ⬇️
pkg/upgrades ∅ <ø> (∅)
see 3 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thomasmaas thomasmaas force-pushed the upgrade-go-1.26.3 branch 3 times, most recently from 6094ad1 to f2d5bd4 Compare June 22, 2026 11:40
@thomasmaas

Copy link
Copy Markdown
Contributor Author

Needs a rebase once #263 has been merged.

Signed-off-by: Thomas Maas <thomas@webtypes.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Dockerfile (1)

2-2: 🧹 Nitpick | 🔵 Trivial | 💤 Low value

Consider pinning the Dockerfile builder image to match go.mod patch version for consistency.

The Dockerfile uses golang:1.26 (latest 1.26.x patch) whilst go.mod specifies 1.26.3 (exact patch). This minor asymmetry is generally safe—both will satisfy Go 1.26+ compatibility—but pinning the Dockerfile to golang:1.26.3 would ensure build reproducibility matches the module directive exactly.

This is a style preference and not a functional issue.

Optional: Pin Dockerfile builder to exact patch version
-FROM --platform=$BUILDPLATFORM mirror.gcr.io/library/golang:1.26 AS builder
+FROM --platform=$BUILDPLATFORM mirror.gcr.io/library/golang:1.26.3 AS builder
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` at line 2, The Dockerfile builder image should be pinned to the
exact patch version for consistency with go.mod. In the FROM instruction that
currently specifies golang:1.26, change the image tag to golang:1.26.3 to match
the exact Go version declared in go.mod and ensure reproducible builds across
environments.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Dockerfile`:
- Line 2: The Dockerfile builder image should be pinned to the exact patch
version for consistency with go.mod. In the FROM instruction that currently
specifies golang:1.26, change the image tag to golang:1.26.3 to match the exact
Go version declared in go.mod and ensure reproducible builds across
environments.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f1a7b75c-5ec0-45fa-bd8b-b5f071ed0a6d

📥 Commits

Reviewing files that changed from the base of the PR and between 08bb9bc and 77e55d3.

📒 Files selected for processing (3)
  • CLAUDE.md
  • Dockerfile
  • go.mod

@thomasmaas

Copy link
Copy Markdown
Contributor Author

Follow-up: #264 — remove hardcoded Go version from docs to avoid drift on future bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants