Upgrade Go to 1.26.3#262
Conversation
Signed-off-by: Thomas Maas <thomas@webtypes.com>
📝 WalkthroughWalkthroughBumps the Go version from 1.25 to 1.26 in three places: the ChangesGo 1.26 Version Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 77.89% 75.86% -2.04%
==========================================
Files 18 18
Lines 1131 1131
==========================================
- Hits 881 858 -23
- Misses 202 217 +15
- Partials 48 56 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
6094ad1 to
f2d5bd4
Compare
|
Needs a rebase once #263 has been merged. |
Signed-off-by: Thomas Maas <thomas@webtypes.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Dockerfile (1)
2-2: 🧹 Nitpick | 🔵 Trivial | 💤 Low valueConsider pinning the Dockerfile builder image to match go.mod patch version for consistency.
The Dockerfile uses
golang:1.26(latest 1.26.x patch) whilst go.mod specifies1.26.3(exact patch). This minor asymmetry is generally safe—both will satisfy Go 1.26+ compatibility—but pinning the Dockerfile togolang:1.26.3would ensure build reproducibility matches the module directive exactly.This is a style preference and not a functional issue.
Optional: Pin Dockerfile builder to exact patch version
-FROM --platform=$BUILDPLATFORM mirror.gcr.io/library/golang:1.26 AS builder +FROM --platform=$BUILDPLATFORM mirror.gcr.io/library/golang:1.26.3 AS builder🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile` at line 2, The Dockerfile builder image should be pinned to the exact patch version for consistency with go.mod. In the FROM instruction that currently specifies golang:1.26, change the image tag to golang:1.26.3 to match the exact Go version declared in go.mod and ensure reproducible builds across environments.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Dockerfile`:
- Line 2: The Dockerfile builder image should be pinned to the exact patch
version for consistency with go.mod. In the FROM instruction that currently
specifies golang:1.26, change the image tag to golang:1.26.3 to match the exact
Go version declared in go.mod and ensure reproducible builds across
environments.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f1a7b75c-5ec0-45fa-bd8b-b5f071ed0a6d
📒 Files selected for processing (3)
CLAUDE.mdDockerfilego.mod
|
Follow-up: #264 — remove hardcoded Go version from docs to avoid drift on future bumps. |
Upgrade Go from 1.25.9 to 1.26.3.
Changes:
go.mod:go 1.25.9→go 1.26.3Dockerfile:mirror.gcr.io/library/golang:1.25→mirror.gcr.io/library/golang:1.26Summary by CodeRabbit