Release 1.5.0 rc3

[eguzki]

• Authorino operator v0.25.1
  • Updates Authorino manifests to v0.26.1 to backport AuthConfig v1beta2 API deprecation fixes. Check release notes for all the updates
• wasm-shim v0.14.1
• Backport Set failure_policy to FAIL_RELOAD #2044
• Backport Fix non-deterministic EnvoyFilter generation #2045
• Backport Cleanup orphaned WasmPlugin objects #2053
  • Excluding commit ed89ee9, due to discussion Cleanup orphaned WasmPlugin objects #2053 (comment) (Revert "Handle error cases" #2067)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 712ac64d-c8ba-4f7b-b238-39cf239e3c67

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch release-1.5.0-rc3

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 37.93103% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.80%. Comparing base (2815276) to head (3cfade6).
⚠️ Report is 1 commits behind head on release-1.5.

Files with missing lines	Patch %	Lines
internal/controller/istio_extension_reconciler.go	0.00%	10 Missing ⚠️
internal/controller/ratelimit_workflow_helpers.go	50.00%	5 Missing ⚠️
internal/istio/utils.go	25.00%	2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (2815276) and HEAD (3cfade6). Click for more details.

HEAD has 5 uploads less than BASE

Flag	BASE (2815276)	HEAD (3cfade6)
controllers-integration	3	0
istio-integration	2	0

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.5    #2065       +/-   ##
================================================
- Coverage        74.98%   59.80%   -15.19%     
================================================
  Files              127      127               
  Lines            12514    12531       +17     
================================================
- Hits              9384     7494     -1890     
- Misses            2648     4582     +1934     
+ Partials           482      455       -27     

Flag	Coverage Δ
bare-k8s-integration	20.28% <0.00%> (+0.03%)	⬆️
controllers-integration	?
envoygateway-integration	41.08% <34.48%> (-0.08%)	⬇️
gatewayapi-integration	16.25% <0.00%> (+0.02%)	⬆️
istio-integration	?
unit	28.25% <20.68%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api (u)	60.21% <ø> (-25.68%)	⬇️
internal (u)	61.06% <37.93%> (-15.39%)	⬇️
pkg (u)	37.95% <ø> (ø)

Files with missing lines	Coverage Δ
...nternal/controller/data_plane_policies_workflow.go	79.56% <100.00%> (-17.41%)	⬇️
internal/istio/utils.go	22.80% <25.00%> (-51.02%)	⬇️
internal/controller/ratelimit_workflow_helpers.go	79.68% <50.00%> (-1.81%)	⬇️
internal/controller/istio_extension_reconciler.go	11.47% <0.00%> (-67.90%)	⬇️

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[guicassolato]

/lgtm

Only caveat is the potential race condition between deleting the WasmPlugin resources before the corresponding EnvoyFilter ones are in place, which could generate some downtime and/or an unprotected gateway. (Also mentioned at #2053 (review).) However, not only this is a temporary solution meant for the transition to the next version of Kuadrant, but also the aforementioned side-effects are arguably less harmful than keeping the WasmPlugin resources in the first place.