Replace --compilers/--procs with -p flag, upgrade Ginkgo to v2.28.3#1949
Replace --compilers/--procs with -p flag, upgrade Ginkgo to v2.28.3#1949madmecodes wants to merge 1 commit into
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughBumps Ginkgo/Gomega and several indirect Go modules in go.mod; removes INTEGRATION_TEST_NUM_CORES/INTEGRATION_TEST_NUM_PROCESSES from make/integration-tests.mk; replaces Ginkgo --compilers/--procs flags with -p in integration targets (keeping --procs=1 for bare-k8s). ChangesGinkgo Upgrade and Integration Test Configuration
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ab648af to
5a6c7f9
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
make/integration-tests.mk (1)
36-36: ⚡ Quick winCoverage profile bloat on high-core CI machines.
When
-pis active, each parallel node produces its own coverage data that Ginkgo merges intocover.out. Running in parallel on high-core-count machines can lead to many duplicated lines in the merged output — on a 64-core machine the mergedcover.outwas reported to reach 7.9 GB, versus 130 MB without-p.If your CI runners are provisioned with many cores and memory is constrained, consider capping parallelism with
--procs=N(e.g., matching the oldINTEGRATION_TEST_NUM_PROCESSES=10) rather than fully auto-detected-p, or verify that the runners have sufficient memory headroom for the merged profile.Also applies to: 55-55, 73-73, 92-92
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@make/integration-tests.mk` at line 36, Replace the Ginkgo '-p' auto-parallel flag to avoid coverage-profile bloat by capping parallelism: change occurrences of the literal '-p' in make/integration-tests.mk to '--procs=$(INTEGRATION_TEST_NUM_PROCESSES)' (and add/ensure the INTEGRATION_TEST_NUM_PROCESSES variable is set or documented), i.e., update each place that passes '-p' to use '--procs=...' so CI can be limited (applies to the '-p' instances referenced around lines 36, 55, 73, 92).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@make/integration-tests.mk`:
- Line 36: Replace the Ginkgo '-p' auto-parallel flag to avoid coverage-profile
bloat by capping parallelism: change occurrences of the literal '-p' in
make/integration-tests.mk to '--procs=$(INTEGRATION_TEST_NUM_PROCESSES)' (and
add/ensure the INTEGRATION_TEST_NUM_PROCESSES variable is set or documented),
i.e., update each place that passes '-p' to use '--procs=...' so CI can be
limited (applies to the '-p' instances referenced around lines 36, 55, 73, 92).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c465d21b-9719-44f3-bf14-a7522f598c79
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
go.modmake/integration-tests.mk
🚧 Files skipped from review as they are similar to previous changes (1)
- go.mod
Upgrade ginkgo from v2.22.0 to v2.28.3 and replace separate --compilers and --procs flags with -p for automatic parallelization in integration test targets. Preserve --procs=1 for test-bare-k8s-integration due to single Kuadrant CR limitation. Remove unused INTEGRATION_TEST_NUM_CORES and INTEGRATION_TEST_NUM_PROCESSES variables. Fixes Kuadrant#1420 Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
5a6c7f9 to
da282ce
Compare
Summary
-pflag support)--compilersand--procsflags with-pin integration test targets for automatic parallelization--procs=1intest-bare-k8s-integration(single Kuadrant CR limitation)INTEGRATION_TEST_NUM_CORESandINTEGRATION_TEST_NUM_PROCESSESvariablesFixes #1420
Test plan
go mod tidyproduces no changes-pflagtest-bare-k8s-integrationcontinues to run serially with--procs=1Summary by CodeRabbit