Skip to content

fix: corrected build argument for docker#341

Closed
DaliborD45 wants to merge 1 commit into
Kuadrant:mainfrom
DaliborD45:data-race-config
Closed

fix: corrected build argument for docker#341
DaliborD45 wants to merge 1 commit into
Kuadrant:mainfrom
DaliborD45:data-race-config

Conversation

@DaliborD45

@DaliborD45 DaliborD45 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The ACTUAL_DEFAULT_AUTHORINO_IMAGE argument was being passed to the Docker build command, but this did not match the argument expected by the Dockerfile. The Dockerfile expects the DEFAULT_AUTHORINO_IMAGE build argument, so this change aligns the build command with the Dockerfile configuration.

Summary by CodeRabbit

  • Chores
    • Updated the Docker build configuration to pass the default Authorino image correctly during builds.

@DaliborD45 DaliborD45 added the area/tooling Makefile and scripts for the dev workflow, testing, etc label Jul 22, 2026
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 020c3e88-8b00-4286-aef6-88750d975bcf

📥 Commits

Reviewing files that changed from the base of the PR and between d2519b1 and 91ea028.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

The docker-build Makefile recipe renames the Docker build argument to DEFAULT_AUTHORINO_IMAGE while retaining the existing image value.

Changes

Docker build argument

Layer / File(s) Summary
Rename Docker build argument
Makefile
The docker-build target now passes $(ACTUAL_DEFAULT_AUTHORINO_IMAGE) through the DEFAULT_AUTHORINO_IMAGE build argument.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: averevki

Poem

A rabbit hops by the Dockerfile gate,
Renaming arguments neat and straight.
The image value stays in sight,
Build context wired just right.
“Hop, hop!” says Bun, “the change is light!”

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: correcting the Docker build argument used during the build.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DaliborD45 DaliborD45 closed this Jul 22, 2026
@github-project-automation github-project-automation Bot moved this to Done in Kuadrant Jul 22, 2026
@DaliborD45
DaliborD45 deleted the data-race-config branch July 22, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tooling Makefile and scripts for the dev workflow, testing, etc

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants