Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,17 @@ describe('flattenCollectionChildren', () => {

expect(childIds).toEqual(['req_first', 'req_mid', 'req_last']);
});

it('de-duplicates documents sharing the same _id', () => {
const data: AllRequestsAndMetaInWorkspace = {
allRequests: [mkReq('req_dup', WS), mkReq('req_dup', WS), mkReq('req_unique', WS)],
allRequestMetas: [],
requestGroupMetas: [],
};
const ids = flattenCollectionChildren(WS, false, data).map(c => c.doc._id);

expect(ids.sort()).toEqual(['req_dup', 'req_unique']);
});
});

// ── filterCollection ───────────────────────────────────────────────────────
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,18 @@ export function flattenCollectionChildren(
const { isRequestGroup } = models.requestGroup;
const collection: Child[] = [];

const seenIds = new Set<string>();
const uniqueRequests = allRequests.filter(doc => {
if (seenIds.has(doc._id)) {
return false;
}
seenIds.add(doc._id);
return true;
});

// map of parentId to its direct children requests and request groups
const requestsByParentId = new Map<string, AllRequestDoc[]>();
for (const req of allRequests) {
for (const req of uniqueRequests) {
const allRequestsByParentId = requestsByParentId.get(req.parentId);
if (allRequestsByParentId) {
allRequestsByParentId.push(req);
Expand Down
Loading