fix(e2e): fix flaky insomnia-vault e2e test (2)#10178
Open
fiosman wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce flakiness in the insomnia-vault smoke test by ensuring a newly-created secret environment variable is actually readable (and therefore likely committed) before navigating away to run a request that depends on it.
Changes:
- After setting the second environment row’s type to Secret, the test now reveals the secret and asserts the value contains
worldbefore leaving the environment editor. - Adds inline commentary documenting the specific flake being addressed (“1 environment variable is missing” modal blocking Send).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Circular References ReportGenerated at: 2026-06-26T23:02:45.721Z Summary
Click to view all circular references in PR (9)Click to view all circular references in base branch (9)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix the
global private sub environment to store vaultsagain. After going through the Playwright trace viewer from the CI artifacts it appears that a missing environment variable modal pops up which prevents Playwright from clicking "Send" to fire off the request.