fix: prevent TypeError on undefined currentPlan.type and path-shim extname#10161
Draft
Copilot wants to merge 2 commits into
Draft
fix: prevent TypeError on undefined currentPlan.type and path-shim extname#10161Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
|
|
1 similar comment
|
|
Copilot
AI
changed the title
[WIP] Fix application error - update
fix: prevent TypeError on undefined currentPlan.type and path-shim extname
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two crash paths that produce
TypeError: Cannot read properties of undefinedin the renderer bundle.mock-response-extractor.tsx— unsafe optional chaincurrentPlanis loaded from localStorage asJSON.parse(... || '{}'). When no plan is cached, it is{}— truthy, socurrentPlan?.typestill evaluates toundefined, and calling.includes()on it throws.path-shim.ts— missing null guardThis file is the Vite
pathalias for the renderer bundle (vite.config.tsaliases'path'→path-shim.ts).extnamecalledp.lastIndexOf('.')with no guard — passingundefinedthrows exactly the reported error. Returns''for falsy input, matching Node.jspath.extnamebehaviour.