Add tags support for S3 objects#651
Open
LouisGarret wants to merge 1 commit into
Open
Conversation
Nek-
suggested changes
Oct 7, 2022
Contributor
There was a problem hiding this comment.
Hello, thank you very much for trying to help to improve Gaufrette.
I have to admit that I do not understand your feature: you can already specify the option Tagging in the constructor of the class. Is there maybe a bundle issue?
(also please provide a test!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Problem: There is no easy way to add tags to S3 objects during upload 😟
Solution: I facilitated tag adding by transforming an array of tags into a query string (format supported by AWS). 😄
Ex:
['public' => 'yes', 'private' => 'no']public=yes&private=noCan you tag the person who is in charge of AWS S3 ? I can't find him (his account no longer exist). ❗
@Nyholm
Have a great day!