-
Notifications
You must be signed in to change notification settings - Fork 353
Fix for the isDir function in the FTP Adapter #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Romain
wants to merge
13
commits into
KnpLabs:master
Choose a base branch
from
Romain:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f21ef3a
Fixed a bug in the FTP Adapter in the way we check if a path is a dir…
Romain 0fc519f
Improved the way we build the URL to optionnaly add the port
Romain 57df9f4
Improved the way we build the URL to take into consideration SSL situ…
Romain d11a658
Keep chdir as the main method, and fallback on is_dir if there's an e…
Romain 8d7a5b0
Missing semi-colon
Romain 32f770a
Applied nicolasmure comments
Romain cb83931
Throw an exception if we try to use is_dir when passive mode is not a…
Romain de3eb22
Some improvements for readability and simplification of the code
Romain 6f31fc2
Removed unused return and unused variable declaration.
Romain 6cc9d88
Removed .idea folder from tracking
Romain 3712db9
Fixed a typo in the FTP protocol name
Romain 81283ac
Resolved conflicts in the .gitignore
Romain c85ef2f
Merge branch 'master' into master
Romain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,3 +9,4 @@ phpunit.xml | |
| tests/adapters/* | ||
| !tests/adapters/*.dist | ||
| vendor/ | ||
| .idea | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.