Skip to content

Split adapters#440

Closed
akerouanton wants to merge 1 commit into
masterfrom
split-adapters
Closed

Split adapters#440
akerouanton wants to merge 1 commit into
masterfrom
split-adapters

Conversation

@akerouanton

@akerouanton akerouanton commented Dec 14, 2016

Copy link
Copy Markdown

Split adapters

https://php-and-symfony.matthiasnoback.nl/2014/04/theres-no-such-thing-as-an-optional-dependency/#the-solution

Why?

Currently, maintaining the whole adapters suite is tough:

  • from time to time, tests break on some adapters and PRs (on another adapter) just can't be merged
  • there're some risks of conflicting requirements between underlying SDKs (already happened! aws/aws-sdk-php v~2 dependency #426)
  • some adapters should be deprecated and might be replaced by something else (e.g. Cache adapter)

Moreover there are some architectural problems:

How?

Split adapters across multiple repositories, then operate needed architectural changes.

TODO:

  • Deprecate adapters we don't want to support anymore
    • AmazonS3
    • Cache (should be rewritten with PSR-16 in mind)
  • Split every adapter in its own namespace and merge it in this branch,
    • AwsS3
    • AzureBlobStorage
    • DoctrineDbal
    • Dropbox
    • Flysystem
    • Ftp
    • GoogleCloudStorage
    • GridFS
    • InMemory
    • Local
    • MogileFS
    • OpenCloud
    • PhpseclibSftp
    • Sftp
    • Zip
  • Merge every possible PRs on master, release the last version on this repository, and freeze the repository,
  • Merge modifications from master into this branch,
  • Push the core in its new repository, update every composer.json,
  • Push every adapter in its new repository
  • Plans for needed architectural changes

@akerouanton akerouanton force-pushed the split-adapters branch 2 times, most recently from f30bca7 to 7c789a9 Compare December 15, 2016 00:06
@akerouanton

Copy link
Copy Markdown
Author

@flug @PedroTroller I've updated the description. What do you think?

@PedroTroller

Copy link
Copy Markdown

Do you keep the root repository with subtree system ?

@flug

flug commented Mar 8, 2017

Copy link
Copy Markdown

@NiR- You have a conflict with .travis.yml

@akerouanton

Copy link
Copy Markdown
Author

@PedroTroller nope: I think the substree split would be useful only for splitting this repository the first time. After that there would be no more central repository.

@flug Yep, it's a WIP pull request/branch hence I don't really care of conflicts for now.

@Nyholm Nyholm deleted the split-adapters branch October 5, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants