Delegate RAG and query enrichment to vtk-mcp#33
Merged
Conversation
Replaces local RAG infrastructure (ChromaDB, llama_index, sentence_transformers, tree_sitter, rag-components submodule, data/examples, db/) with vtk-mcp as the single source of VTK knowledge, context retrieval, and code validation. When --mcp-url is set: - Context is always fetched via hybrid vector search (vector_search_examples + vector_search_docs) and class hints (vtk_get_class_info, vtk_get_class_action_phrase) - The LLM has access to all vtk-mcp tools during generation (agentic tool loop) - Generated code is validated with validate_vtk_code; diagnostics trigger a retry Changes: - vtk_mcp_client.py: new HTTP JSON-RPC client wrapping vtk-mcp tools - client.py: removed ChromaDB paths; rag param removed; mcp_url drives everything - cli.py: --rag/--collection/--database replaced by --mcp-url - UI: RAG checkbox removed; Top K active when vtk-mcp URL is set - provider_utils.py: updated model lists (Anthropic claude-4.x, OpenAI gpt-4.1, NIM llama-3.3); default changed to anthropic/claude-sonnet-4-6 - pyproject.toml: removed all RAG deps; bumped vtk>=9.6.1 - CI: uv-vtk-mcp-smoke job installs vtk-mcp + GitHub deps via uv - Deleted: rag_chat_wrapper.py, build_rag_db.py, test_rag.py, rag-components/, data/, db/
Closed
Collaborator
|
+2 |
jlee-kitware
reviewed
Jun 4, 2026
jlee-kitware
left a comment
jlee-kitware
left a comment
Collaborator
There was a problem hiding this comment.
+2
lots of files changed, assuming this is cleanup and you have tests to validate regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces local RAG infrastructure (ChromaDB, llama_index, rag-components) with vtk-mcp as the single source of VTK knowledge.
What changed
vtk_mcp_client.py: new HTTP JSON-RPC client — hybrid vector search (vector_search_examples+vector_search_docs), class hints, and full code validation viavalidate_vtk_codeclient.py: context retrieval and validation always active whenmcp_urlis set; LLM has access to all vtk-mcp tools during generation;validate_vtk_codediagnostics fed back for retrycli.py:--rag/--collection/--databasereplaced by--mcp-urlanthropic/claude-sonnet-4-6uv-vtk-mcp-smokejob installs vtk-mcp and its GitHub-hosted deps via uvrag_chat_wrapper.py,build_rag_db.py,test_rag.py,rag-components/,data/,db/Usage