Skip to content

Mappings for admin API for creating and destroying topics#12

Open
kacperk wants to merge 24 commits into
Kitura:masterfrom
letsbuilders:master
Open

Mappings for admin API for creating and destroying topics#12
kacperk wants to merge 24 commits into
Kitura:masterfrom
letsbuilders:master

Conversation

@kacperk

@kacperk kacperk commented Mar 1, 2021

Copy link
Copy Markdown

Fouad Hatem added 2 commits September 28, 2020 00:46
Update package references from IBM-Swift to Kitura
Update various resource references from IBM-Swift to Kitura wherever applicable.
@CLAassistant

CLAassistant commented Mar 1, 2021

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kacperk
❌ Fouad Hatem


Fouad Hatem seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dannys42

dannys42 commented Mar 2, 2021

Copy link
Copy Markdown

@kacperk Thanks for your submission and for making the org changes that got missed! Are you able to view the Travis failures? Just in case you're not able to, here are the relevant error messages:

  • Linux swift-5.2-DEVELOPMENT-SNAPSHOT-2020-04-27-a:
/home/travis/build/Kitura/SwiftKafka/Sources/SwiftKafka/KafkaTopicSpecification.swift:17:44: error: expression resolves to an unused property
667    public var options: [String: String] { _options }
  • Linux swift-5.2-DEVELOPMENT-SNAPSHOT-2020-04-27-a:
2021-03-01T10:28:10+0000 warning KafkaClientLogger : Failed to create topic test5 with error Invalid replication factor
823
  • macOS 10.14.4 Apple Swift version 5.0.1 (swiftlang-1001.0.82.4 clang-1001.0.46.5):
7561/Users/travis/build/Kitura/SwiftKafka/Sources/SwiftKafka/KafkaTopicSpecification.swift:17:44: error: expression resolves to an unused property
7562    public var options: [String: String] { _options }
7563

@kacperk

kacperk commented Mar 9, 2021

Copy link
Copy Markdown
Author

@dannys42 I can view errors on Travis. I will fix it as soon as I will find a time for it.

@kacperk

kacperk commented Apr 7, 2021

Copy link
Copy Markdown
Author

@dannys42 I've fixed errors in my code so test on Linux are passing without any problem. Test on Mac wasn't passing since it is running newer Kafka which require topics to be created before consuming from them - I've fix it by creating topic first.

@sonarqubecloud

sonarqubecloud Bot commented Apr 8, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants