Skip to content

[18.0][MIG] document_knowledge: Migration to 18.0#1

Open
Kimkhoi3010 wants to merge 46 commits into
18.0from
18.0-mig-document_knowledge
Open

[18.0][MIG] document_knowledge: Migration to 18.0#1
Kimkhoi3010 wants to merge 46 commits into
18.0from
18.0-mig-document_knowledge

Conversation

@Kimkhoi3010

Copy link
Copy Markdown
Owner

No description provided.

@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-document_knowledge branch 3 times, most recently from 8bec733 to 9d76f0f Compare October 29, 2024 11:11

@xaviedoanhduy xaviedoanhduy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

The filters work quite effectively
image

Comment thread document_knowledge/views/res_config.xml Outdated
name="maintenance_mode_setting"
title="Knowledge and Documents Management"
>
<setting>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<setting>
<setting
id="attachment_indexation"
help="Document indexation, full text search of attachements.
- This installs the module attachment_indexation."
>

On this occasion, can you add ID and help attributes, because on the form view of res.config.settings, the help attribute on the module does not seem to have much effect.
an example: https://github.com/odoo/odoo/blob/f4c7e3e7ce87f0bc0bfadd01852c25b008354f19/addons/stock/views/res_config_settings_views.xml#L16

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't any help displayed even when debugging is enabled
image

@xaviedoanhduy

Copy link
Copy Markdown

btw,

Squash administrative commits (if any) with the previous commit for reducing commit noise. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details.

@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-document_knowledge branch from 9d76f0f to e2e9fd3 Compare November 1, 2024 04:03
ivantodorovich and others added 11 commits November 1, 2024 11:05
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Otherwise the module grants too wide permissions for all users.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-12.0/knowledge-12.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-knowledge/
Currently translated at 57.7% (15 of 26 strings)

Translation: knowledge-12.0/knowledge-12.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-knowledge/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-13.0/knowledge-13.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/
OCA-git-bot and others added 21 commits November 1, 2024 11:05
Currently translated at 57.7% (15 of 26 strings)

Translation: knowledge-13.0/knowledge-13.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/he_IL/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-13.0/knowledge-13.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/
Currently translated at 100.0% (26 of 26 strings)

Translation: knowledge-13.0/knowledge-13.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/ru/
Currently translated at 88.4% (23 of 26 strings)

Translation: knowledge-15.0/knowledge-15.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-knowledge/tr/
Currently translated at 100.0% (26 of 26 strings)

Translation: knowledge-15.0/knowledge-15.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-knowledge/fr/
In v16 Odoo has its own knowledge module
Currently translated at 100.0% (21 of 21 strings)

Translation: knowledge-17.0/knowledge-17.0-document_knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_knowledge/sv/
Currently translated at 100.0% (21 of 21 strings)

Translation: knowledge-17.0/knowledge-17.0-document_knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_knowledge/ca/
[IMP] document_knowledge: pre-commit execution
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-document_knowledge branch from e2e9fd3 to 5fd6a9e Compare November 1, 2024 04:05

@xaviedoanhduy xaviedoanhduy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-document_knowledge branch 4 times, most recently from 6b28bbe to 986fef4 Compare November 13, 2024 08:45
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-document_knowledge branch from 986fef4 to f82dce4 Compare November 13, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.