Repository navigation
fix(features): make HTTP/1 serving a required dependency - #118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gotcha still exposes an optional
http1switch left over from Cloudflare Worker support. A standalone consumer withdefault-features = falsefails inside the library ataxum::serve, although HTTP serving is now a required framework capability.Enable Axum's
http1andtokiofeatures directly on the dependency and remove gotcha's obsoletehttp1feature. All startup APIs remain unconditional, including with defaults disabled. Update the examples, feature matrix, and migration documentation to match.Compatibility: remove
"http1"from explicit gotcha feature lists. Default application behavior is unchanged; OpenAPI, metrics, CORS, static files, and tasks remain optional.gotcha_coreremains available for schema-only libraries.Validation:
openapi, without workspace feature unification.Local validation passed: standalone consumers, gotcha tests and doctests with defaults disabled and with all features, workspace Clippy with warnings denied, formatting, and documentation builds with warnings denied.
All 11 Rust CI checks passed on
bc2838b0a5443a3484713aab6a292601cc3609ae.Fixes #116.