loader: Fix double free on Windows#1950
Merged
Merged
Conversation
|
Author hrkkk not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author hrkkk not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
charles-lunarg
approved these changes
Jun 25, 2026
|
CI Vulkan-Loader build queued with queue ID 18011. |
|
CI Vulkan-Loader build # 3590 running. |
|
CI Vulkan-Loader build # 3590 passed. |
Collaborator
|
For me to be able to merge this, I need you to sign the CLA. If you don't want to or can't for some reason, just say so and I can make a replacement commit so that this fix gets in. |
hrkkk
force-pushed
the
fix-double-free-bug
branch
from
91dbb3b to
de38ca2
Compare
|
Author hrkkk not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author hrkkk not on autobuild list. Waiting for curator authorization before starting CI build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If the path pointer is not null after loader_instance_heap_free(), it would be free twice and trigger crash on Windows.