Use string lists for manifest search paths#1928
Conversation
|
CI Vulkan-Loader build queued with queue ID 765074. |
|
CI Vulkan-Loader build queued with queue ID 765091. |
|
While not an implementation, this PR will make #1401 simpler as all of the search paths are tracked individually rather than in one giant string. |
|
CI Vulkan-Loader build # 3536 running. |
|
CI Vulkan-Loader build # 3536 failed. |
charles-lunarg
force-pushed
the
use_string_list_for_search_paths
branch
from
c65f0a0 to
8348e7f
Compare
|
CI Vulkan-Loader build queued with queue ID 765185. |
|
CI Vulkan-Loader build # 3538 running. |
|
CI Vulkan-Loader build # 3538 failed. |
charles-lunarg
force-pushed
the
use_string_list_for_search_paths
branch
from
8348e7f to
aa95552
Compare
|
CI Vulkan-Loader build queued with queue ID 765350. |
|
CI Vulkan-Loader build queued with queue ID 765388. |
|
CI Vulkan-Loader build # 3540 running. |
|
CI Vulkan-Loader build # 3540 failed. |
charles-lunarg
force-pushed
the
use_string_list_for_search_paths
branch
from
aa95552 to
961821d
Compare
|
CI Vulkan-Loader build queued with queue ID 766239. |
|
CI Vulkan-Loader build # 3543 running. |
charles-lunarg
force-pushed
the
use_string_list_for_search_paths
branch
from
961821d to
601d69b
Compare
|
CI Vulkan-Loader build queued with queue ID 766364. |
charles-lunarg
force-pushed
the
use_string_list_for_search_paths
branch
from
601d69b to
9984a16
Compare
|
CI Vulkan-Loader build queued with queue ID 766443. |
|
CI Vulkan-Loader build # 3546 running. |
|
CI Vulkan-Loader build # 3546 aborted. |
charles-lunarg
force-pushed
the
use_string_list_for_search_paths
branch
from
9984a16 to
40826ed
Compare
|
CI Vulkan-Loader build queued with queue ID 1613. |
|
CI Vulkan-Loader build queued with queue ID 1630. |
|
CI Vulkan-Loader build # 3550 running. |
|
CI Vulkan-Loader build # 3550 failed. |
charles-lunarg
force-pushed
the
use_string_list_for_search_paths
branch
from
40826ed to
8cba83d
Compare
|
CI Vulkan-Loader build queued with queue ID 1670. |
|
CI Vulkan-Loader build # 3552 running. |
|
CI Vulkan-Loader build # 3552 passed. |
charles-lunarg
force-pushed
the
use_string_list_for_search_paths
branch
from
8cba83d to
34fbabe
Compare
|
CI Vulkan-Loader build queued with queue ID 1739. |
|
CI Vulkan-Loader build queued with queue ID 1756. |
charles-lunarg
force-pushed
the
use_string_list_for_search_paths
branch
from
34fbabe to
076b26d
Compare
|
CI Vulkan-Loader build queued with queue ID 1760. |
|
CI Vulkan-Loader build # 3555 running. |
|
CI Vulkan-Loader build # 3555 passed. |
We stored the return value of realloc in new_ptr, but never checked its value against NULL, which hides OOM issues.
Rather than try to combine all search paths into a single giant string, add each path to a list of strings, deduplicating as we go. This simplifies the logic to get all of the search paths by not needing to first sum up the lengths of all of the search paths in order to allocate a single large string, or having to reallocate the string if it isn't large enough. This commit modifies loader_windows.c to be more uniform with the rest of the code by returning VkResult directly rather than as an out parameter.
charles-lunarg
force-pushed
the
use_string_list_for_search_paths
branch
from
076b26d to
a7cbdfa
Compare
|
CI Vulkan-Loader build queued with queue ID 2765. |
|
CI Vulkan-Loader build queued with queue ID 2782. |
|
CI Vulkan-Loader build # 3557 running. |
|
CI Vulkan-Loader build # 3557 passed. |
|
Merging as I did a self-review and didn't find anything egregious. |
2 participants
Rather than try to combine all search paths into a single giant string, add each path to a list of strings, deduplicating as we go. This simplifies the logic to get all of the search paths by not needing to first sum up the lengths of all of the search paths in order to allocate a single large string, or having to reallocate the string if it isn't large enough.