Skip to content

loader: Use VULKAN_DIR macro in pathes#1802

Merged
charles-lunarg merged 1 commit into
KhronosGroup:mainfrom
RasterGrid:hapakj/using_vulkan_dir_macro
Nov 12, 2025
Merged

loader: Use VULKAN_DIR macro in pathes#1802
charles-lunarg merged 1 commit into
KhronosGroup:mainfrom
RasterGrid:hapakj/using_vulkan_dir_macro

Conversation

@hapakj

@hapakj hapakj commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

Use VULKAN_DIR macro in pathes.
Also introduces TESTING_VULKAN_DIR macro in test framework.

It helps to handle the different implementations more clearly between APIs (e.g. Vulkan SC)

@ci-tester-lunarg

Copy link
Copy Markdown

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

Copy link
Copy Markdown

Author hapakj not on autobuild list. Waiting for curator authorization before starting CI build.

Also introduce TESTING_VULKAN_DIR macro in test framework
@hapakj hapakj force-pushed the hapakj/using_vulkan_dir_macro branch from 84fd571 to 0d6511b Compare November 10, 2025 18:20
@hapakj

hapakj commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

@charles-lunarg could you review this change, please?

@charles-lunarg charles-lunarg merged commit c0c74b8 into KhronosGroup:main Nov 12, 2025
45 checks passed
@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 596397.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3320 running.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3320 failed.

@charles-lunarg

Copy link
Copy Markdown
Collaborator

Seems that because this didn't get run through internal CI earlier, it only now was run. But since the PR is merged, the branch was deleted so CI failed to checkout the commit.

In other words, safe to ignore.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 8541.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3568 running.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3568 failed.

@charles-lunarg

Copy link
Copy Markdown
Collaborator

Miss click, I can trigger internal CI builds and this was done by mistake for this old PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants