Check return value of copy_surface_create_info#1780
Merged
charles-lunarg merged 1 commit intoOct 2, 2025
Merged
Conversation
Not propagating the error code meant that unknown structs in the pNext chains of surface create info structs caused crashes later that should have been prevented. This also allows Out Of Memory conditions to be propagated correctly
|
CI Vulkan-Loader build queued with queue ID 543858. |
|
CI Vulkan-Loader build queued with queue ID 543875. |
|
CI Vulkan-Loader build # 3210 running. |
|
CI Vulkan-Loader build # 3210 passed. |
aqnuep
approved these changes
Oct 1, 2025
charles-lunarg
deleted the
wsi_check_error_code_of_copy_surface_create_info
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not propagating the error code meant that unknown structs in the pNext chains of surface create info structs caused crashes later that should have been prevented. This also allows Out Of Memory conditions to be propagated correctly