Skip to content

Fix API version name handling#1677

Merged
charles-lunarg merged 1 commit into
KhronosGroup:mainfrom
RasterGrid:version-handling-fix
Jun 3, 2025
Merged

Fix API version name handling#1677
charles-lunarg merged 1 commit into
KhronosGroup:mainfrom
RasterGrid:version-handling-fix

Conversation

@MathiasMagnus

Copy link
Copy Markdown
Contributor

Recent refactoring broke downstream version name handling. These changes have no effect on Vulkan, but enables proper handling for Vulkan SC.

@ci-tester-lunarg

Copy link
Copy Markdown

Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

Copy link
Copy Markdown

Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build.

@aqnuep aqnuep requested a review from charles-lunarg March 18, 2025 16:05
@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 405299.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 2994 running.

@charles-lunarg

Copy link
Copy Markdown
Collaborator

Seems that recent changes cause this PR to need rebasing. I could try rebasing it but I would rather let the people who have the downstream usage of Vulkan-Loader be the ones to do it.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 2994 passed.

@charles-lunarg

Copy link
Copy Markdown
Collaborator

I went ahead and rebased locally to see what the conflicts are - seems that spencer switched '' and "" in a recent PR. So its a very simple conflict to fix thankfully. I don't have permissions to push it to the fork/branch, but I am happy to make the rebased PR available.

Recent refactoring broke downstream version name handling. These changes have no effect on Vulkan, but enables proper handling for Vulkan SC.
@MathiasMagnus MathiasMagnus force-pushed the version-handling-fix branch from 2f7c631 to 8ff7baa Compare June 3, 2025 13:33
@ci-tester-lunarg

Copy link
Copy Markdown

Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

Copy link
Copy Markdown

Author MathiasMagnus not on autobuild list. Waiting for curator authorization before starting CI build.

@MathiasMagnus

Copy link
Copy Markdown
Contributor Author

@charles-lunarg I've rebased the scripts on top of latest main. Please consider merging should CI run and finish correctly.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 456994.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3051 running.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3051 passed.

@charles-lunarg charles-lunarg merged commit bf4aec7 into KhronosGroup:main Jun 3, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants