Skip to content

feat: Adds dmail to the web wallet#886

Merged
macterra merged 22 commits into
mainfrom
885-add-dmail
Jun 11, 2025
Merged

feat: Adds dmail to the web wallet#886
macterra merged 22 commits into
mainfrom
885-add-dmail

Conversation

@macterra

@macterra macterra commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

This pull request adds support for Dmail in the web wallet by introducing new API endpoints, client methods, and related tests. Key changes include:

  • New tests for Dmail functionality in the keymaster tests.
  • Addition of Dmail endpoints and swagger documentation in the keymaster API.
  • Updates in types and implementations within the keymaster and keymaster-client packages to integrate Dmail features.

@macterra macterra linked an issue Jun 5, 2025 that may be closed by this pull request
@macterra
macterra requested a review from Copilot June 11, 2025 18:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for Dmail in the web wallet by introducing new API endpoints, client methods, and related tests. Key changes include:

  • New tests for Dmail functionality in the keymaster tests.
  • Addition of Dmail endpoints and swagger documentation in the keymaster API.
  • Updates in types and implementations within the keymaster and keymaster-client packages to integrate Dmail features.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/keymaster/name.test.ts Added a test verifying that IDs are included when requested.
tests/keymaster/client.test.ts Introduced tests for Dmail operations (create, update, send, remove, import, list, and get message).
services/keymaster/server/src/keymaster-api.ts Added swagger-documented endpoints for Dmail operations.
packages/keymaster/src/types.ts Introduced new interfaces for Dmail messages and items.
packages/keymaster/src/keymaster.ts Implemented Dmail methods and integrated them with existing group vault logic.
packages/keymaster/src/keymaster-client.ts Updated client methods to handle Dmail endpoints with consistent option types.
packages/ipfs/src/helia-client.ts Minor update with replacement of commented import using updated libp2p creation.
doc/keymaster-api.json Updated API documentation JSON to include new Dmail endpoints.
Comments suppressed due to low confidence (2)

packages/keymaster/src/keymaster.ts:1469

  • [nitpick] Review the merging of wallet.names and wallet.ids: if both objects contain the same key, the latter may overwrite the former. Clarify or document the intended behavior to avoid potential confusion.
if (includeIDs) { for (const [name, id] of Object.entries(wallet.ids || {}) { names[name] = id.did; } }

packages/keymaster/src/keymaster.ts:3148

  • [nitpick] Consider adding a reference (e.g., a ticket or comment with additional context) for the pending implementation of creating a notice for recipients. This will help future maintainers understand the current placeholder and planned enhancements.
// TBD create notice for the recipients

Comment thread services/keymaster/server/src/keymaster-api.ts Outdated
@macterra
macterra merged commit 2255631 into main Jun 11, 2025
13 checks passed
@macterra
macterra deleted the 885-add-dmail branch June 11, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dmail to web wallet

2 participants