feat: Adds dmail to the web wallet#886
Merged
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for Dmail in the web wallet by introducing new API endpoints, client methods, and related tests. Key changes include:
- New tests for Dmail functionality in the keymaster tests.
- Addition of Dmail endpoints and swagger documentation in the keymaster API.
- Updates in types and implementations within the keymaster and keymaster-client packages to integrate Dmail features.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/keymaster/name.test.ts | Added a test verifying that IDs are included when requested. |
| tests/keymaster/client.test.ts | Introduced tests for Dmail operations (create, update, send, remove, import, list, and get message). |
| services/keymaster/server/src/keymaster-api.ts | Added swagger-documented endpoints for Dmail operations. |
| packages/keymaster/src/types.ts | Introduced new interfaces for Dmail messages and items. |
| packages/keymaster/src/keymaster.ts | Implemented Dmail methods and integrated them with existing group vault logic. |
| packages/keymaster/src/keymaster-client.ts | Updated client methods to handle Dmail endpoints with consistent option types. |
| packages/ipfs/src/helia-client.ts | Minor update with replacement of commented import using updated libp2p creation. |
| doc/keymaster-api.json | Updated API documentation JSON to include new Dmail endpoints. |
Comments suppressed due to low confidence (2)
packages/keymaster/src/keymaster.ts:1469
- [nitpick] Review the merging of wallet.names and wallet.ids: if both objects contain the same key, the latter may overwrite the former. Clarify or document the intended behavior to avoid potential confusion.
if (includeIDs) { for (const [name, id] of Object.entries(wallet.ids || {}) { names[name] = id.did; } }
packages/keymaster/src/keymaster.ts:3148
- [nitpick] Consider adding a reference (e.g., a ticket or comment with additional context) for the pending implementation of creating a notice for recipients. This will help future maintainers understand the current placeholder and planned enhancements.
// TBD create notice for the recipients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Dmail in the web wallet by introducing new API endpoints, client methods, and related tests. Key changes include: