fix: make common logger browser safe#1219
Merged
Merged
Conversation
jahatch512
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes @mdip/common safe to consume from browser builds while preserving the existing Node logger behavior. It adds browser-specific package export entries and a lightweight browser logger implementation that avoids Node-only assumptions such as process.env and pretty-print transports.
It also updates the Node logger to use pino-pretty as a stream instead of a transport for better CommonJS compatibility, and adjusts IPFS CID imports to use the explicit multiformats/cid subpath. A focused logger test was updated to cover the browser-safe environment fallback and the new pretty-stream behavior.