Skip to content

feat: android scan credential QR code#1035

Merged
Bushstar merged 1 commit into
mainfrom
bush/android-cred
Sep 29, 2025
Merged

feat: android scan credential QR code#1035
Bushstar merged 1 commit into
mainfrom
bush/android-cred

Conversation

@Bushstar

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds QR code scanning functionality for credential DIDs on Android by implementing a reusable QR scanner utility and integrating it into both the authentication and credential management workflows.

  • Consolidates QR scanning logic into a shared utility function
  • Enhances DID extraction to support multiple URL protocols (mdip:, https:, http:) and query parameter patterns
  • Adds QR scan button to the credential input field in HeldTab

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
apps/android/src/utils/utils.ts Adds BarcodeScanner import, enhances extractDid function with expanded protocol support, and implements scanQrCode utility function
apps/android/src/components/HeldTab.tsx Integrates QR scanning functionality with camera icon button in credential input field
apps/android/src/components/AuthTab.tsx Refactors to use shared scanQrCode utility, removing duplicated scanning logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread apps/android/src/utils/utils.ts
Comment thread apps/android/src/utils/utils.ts
Comment thread apps/android/src/components/HeldTab.tsx
@Bushstar Bushstar merged commit 1062686 into main Sep 29, 2025
15 checks passed
@Bushstar Bushstar deleted the bush/android-cred branch September 29, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: add ability to scan credential from QR code

3 participants