feat: android scan credential QR code#1035
Merged
Merged
Conversation
Bushstar
commented
Sep 28, 2025
Contributor
- Resolves: Android: add ability to scan credential from QR code #1034
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds QR code scanning functionality for credential DIDs on Android by implementing a reusable QR scanner utility and integrating it into both the authentication and credential management workflows.
- Consolidates QR scanning logic into a shared utility function
- Enhances DID extraction to support multiple URL protocols (mdip:, https:, http:) and query parameter patterns
- Adds QR scan button to the credential input field in HeldTab
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/android/src/utils/utils.ts | Adds BarcodeScanner import, enhances extractDid function with expanded protocol support, and implements scanQrCode utility function |
| apps/android/src/components/HeldTab.tsx | Integrates QR scanning functionality with camera icon button in credential input field |
| apps/android/src/components/AuthTab.tsx | Refactors to use shared scanQrCode utility, removing duplicated scanning logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
macterra
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.