chore: ext add DID list registry drop down#1031
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a DID list registry dropdown filter and enhances various UI components with improved handling for DID operations. The changes primarily focus on adding registry filtering capabilities to the Named DIDs component and improving user experience across schema, group, and vault management interfaces.
- Adds registry filtering functionality to the Named DIDs list with a dropdown filter
- Enhances JSON viewer with inline resolve/decrypt buttons and Enter key support
- Improves name validation and copy/resolve DID functionality across Schema, Group, and GroupVault tabs
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| UIContext.tsx | Adds nameRegistry state and registry mapping extraction during name refresh |
| CredentialsProvider.tsx | Adds nameRegistry state management to credentials context |
| SchemaTab.tsx | Improves name validation, removes unused state, and fixes copy/resolve DID handling |
| NamedDIDs.tsx | Adds registry filter dropdown and fixes select all/deselect functionality |
| JsonViewer.tsx | Replaces separate buttons with inline icons and adds Enter key support for resolve |
| GroupsTab.tsx | Improves name validation and fixes copy/resolve DID handling |
| GroupVaultTab.tsx | Improves name validation and fixes copy/resolve DID handling |
Comments suppressed due to low confidence (1)
browser/chrome-extension/src/browser/components/NamedDIDs.tsx:295
- The function references
someSelectedOnPageandallVisibleNamesvariables that are not defined in the visible code scope, which will cause runtime errors.
const toggleSelectAllVisible = () => {
setSelected((prev) => {
const next = new Set(prev);
if (someSelectedOnPage) {
allVisibleNames.forEach((n) => next.delete(n));
} else {
allVisibleNames.forEach((n) => next.add(n));
}
return next;
});
};
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
macterra
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.