Skip to content

chore: ext add DID list registry drop down#1031

Merged
Bushstar merged 2 commits into
mainfrom
bush/ext-fixes
Sep 15, 2025
Merged

chore: ext add DID list registry drop down#1031
Bushstar merged 2 commits into
mainfrom
bush/ext-fixes

Conversation

@Bushstar

@Bushstar Bushstar commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a DID list registry dropdown filter and enhances various UI components with improved handling for DID operations. The changes primarily focus on adding registry filtering capabilities to the Named DIDs component and improving user experience across schema, group, and vault management interfaces.

  • Adds registry filtering functionality to the Named DIDs list with a dropdown filter
  • Enhances JSON viewer with inline resolve/decrypt buttons and Enter key support
  • Improves name validation and copy/resolve DID functionality across Schema, Group, and GroupVault tabs

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
UIContext.tsx Adds nameRegistry state and registry mapping extraction during name refresh
CredentialsProvider.tsx Adds nameRegistry state management to credentials context
SchemaTab.tsx Improves name validation, removes unused state, and fixes copy/resolve DID handling
NamedDIDs.tsx Adds registry filter dropdown and fixes select all/deselect functionality
JsonViewer.tsx Replaces separate buttons with inline icons and adds Enter key support for resolve
GroupsTab.tsx Improves name validation and fixes copy/resolve DID handling
GroupVaultTab.tsx Improves name validation and fixes copy/resolve DID handling
Comments suppressed due to low confidence (1)

browser/chrome-extension/src/browser/components/NamedDIDs.tsx:295

  • The function references someSelectedOnPage and allVisibleNames variables that are not defined in the visible code scope, which will cause runtime errors.
    const toggleSelectAllVisible = () => {
        setSelected((prev) => {
            const next = new Set(prev);
            if (someSelectedOnPage) {
                allVisibleNames.forEach((n) => next.delete(n));
            } else {
                allVisibleNames.forEach((n) => next.add(n));
            }
            return next;
        });
    };

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread browser/chrome-extension/src/browser/components/GroupVaultTab.tsx
@Bushstar Bushstar merged commit 6dac856 into main Sep 15, 2025
14 checks passed
@Bushstar Bushstar deleted the bush/ext-fixes branch September 15, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DID field should show full DID Service field empty Extension: Add drop down registry filter to named DID list

3 participants