chore: gatekeeper fix race condition in SQLite DB#1028
Merged
Conversation
Bushstar
commented
Sep 12, 2025
Contributor
- Resolves: Fix race condition in Gatekeeper SQLite DB #1026
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a race condition in the SQLite database implementation by introducing proper concurrency control mechanisms. The changes ensure database operations are executed safely in a concurrent environment through transaction management and exclusive operation execution.
- Adds a locking mechanism (
runExclusive) to prevent concurrent database operations - Wraps database operations in transactions using a new
withTxhelper method - Refactors existing methods to use the new concurrency-safe patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/gatekeeper/src/db/sqlite.ts | Implements concurrency control with runExclusive method, transaction wrapper, and refactors all database operations to use these safety mechanisms |
| packages/gatekeeper/src/db/redis.ts | Removes unnecessary runExclusive wrapper from removeFromBatch method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
macterra
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.