chore: prevent DB race on Keymaster#1020
Merged
Merged
Conversation
Bushstar
commented
Sep 9, 2025
Contributor
- Resolves: Prevent keymaster race condition on wallet #1019
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents database race conditions in Keymaster by implementing a centralized wallet mutation mechanism with locking. The changes address potential concurrency issues where multiple operations could modify the wallet simultaneously, ensuring thread-safe operations through an abstract base class with built-in locking.
- Introduces
AbstractBaseclass with a promise-based locking mechanism for wallet operations - Refactors all wallet storage classes to extend
AbstractBaseinstead of implementingWalletBasedirectly - Replaces direct load/modify/save patterns with atomic
mutateWalletoperations throughout Keymaster
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/keymaster/src/db/abstract-base.ts | New abstract base class providing thread-safe updateWallet method with promise-based locking |
| packages/keymaster/src/types.ts | Adds updateWallet method to WalletBase interface |
| packages/keymaster/src/keymaster.ts | Refactors wallet operations to use new mutateWallet helper for atomic updates |
| packages/keymaster/src/db/*.ts | Updates all wallet storage implementations to extend AbstractBase |
| tests/keymaster/wallet.test.ts | Adds test coverage for new functionality |
| packages/keymaster/rollup.cjs.config.js | Adds build configuration for new abstract base module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
Just for the record, no material change to keymaster service performance (using json db). Running |
macterra
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.