Skip to content

chore: update Satoshi mediator#1017

Merged
Bushstar merged 2 commits into
mainfrom
bush/sat-updates
Sep 8, 2025
Merged

chore: update Satoshi mediator#1017
Bushstar merged 2 commits into
mainfrom
bush/sat-updates

Conversation

@Bushstar

@Bushstar Bushstar commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

@Bushstar Bushstar requested review from Copilot and macterra September 8, 2025 10:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Satoshi mediator with significant improvements to database operations, fee management, and RBF (Replace-By-Fee) handling. It introduces smart fee estimation, fixes race conditions in database operations, and updates the bitcoin-core library to version 5.0.0.

Key changes include:

  • Replaces fixed minimum fees with smart fee estimation and RBF chain management
  • Introduces atomic database operations via updateDb to prevent race conditions
  • Updates bitcoin-core to 5.0.0 and modernizes transaction creation logic

Reviewed Changes

Copilot reviewed 22 out of 26 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
tests/cli-tests/generate_test_env.sh Updates environment variable names for fee configuration
services/mediators/satoshi/package.json Updates bitcoin-core dependency to version 5.0.0
services/mediators/satoshi/src/config.ts Replaces fee min/increment with block target/fallback and RBF settings
services/mediators/satoshi/src/types.ts Adds updateDb interface and changes pending structure to support RBF chains
services/mediators/satoshi/src/satoshi-mediator.ts Major refactor with smart fees, RBF chain handling, and atomic DB operations
services/mediators/satoshi/src/db/* Adds AbstractDB base class with updateDb implementation for all DB adapters
Configuration files Updates environment variable mappings across docker-compose and documentation
Files not reviewed (1)
  • services/mediators/satoshi/package-lock.json: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread services/mediators/satoshi/src/types.ts Outdated
Comment thread services/mediators/satoshi/src/satoshi-mediator.ts Outdated
Comment thread services/mediators/satoshi/src/satoshi-mediator.ts Outdated
Comment thread services/mediators/satoshi/src/satoshi-mediator.ts
Comment thread services/mediators/satoshi/src/satoshi-mediator.ts Outdated
Comment thread services/mediators/satoshi/src/satoshi-mediator.ts Outdated
Comment thread services/mediators/satoshi/src/satoshi-mediator.ts
Comment thread services/mediators/satoshi/src/satoshi-mediator.ts
Comment thread services/mediators/satoshi-inscription/src/inscription-mediator.ts Outdated
@Bushstar Bushstar merged commit c26160b into main Sep 8, 2025
14 checks passed
@Bushstar Bushstar deleted the bush/sat-updates branch September 8, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Satoshi mediator replace feeMin/feeInc with estimateSmartFee RPC and run RBF on block height

3 participants