Add CEcalRegistrationDatabase core, direct mutation API, and initial GTests by KerstinKeller · Pull Request #3 · KerstinKeller/ecal

KerstinKeller · 2026-02-20T14:16:55Z

Motivation

Avoid forwarding full Registration::Sample objects everywhere by providing a deserializer-friendly direct mutation API for registration updates to reduce deserialization cost and duplicated state reconstruction.
Establish a canonical, normalized store that separates hot monitoring fields from cold registration payloads and provides deterministic revision semantics for incremental migration.
Ensure safe lifecycle semantics by codifying cascade-delete behavior for process removal so member entities (publishers/subscribers/servers/clients) are removed atomically with their monitoring state.

Description

Implemented a first CEcalRegistrationDatabase in ecal/core/src/registration/ with split registration vs monitoring stores, current + previous revision tracking, snapshot read semantics, and process-member tracking (ecal_registration_database.h/.cpp).
Added direct mutation APIs (AddOrUpdate* / Update*Monitoring / Remove*) and sample compatibility adapters (ApplySample / ApplySamples) which map incoming Registration::Sample commands to the direct APIs.
Implemented process cascade-delete that removes all member entities and their monitoring entries when a process is removed.
Registered the new core sources in ecal/core/CMakeLists.txt and added initial GTests in ecal/tests/cpp/registration_test/src/registration_database_test.cpp, and wired the test into ecal/tests/cpp/registration_test/CMakeLists.txt.

Testing

Ran a file-level C++ syntax check of the new core source with g++ -std=c++14 -fsyntax-only which succeeded for ecal_registration_database.cpp.
Attempted full project configuration with cmake --preset core but configuration failed due to missing third-party submodule trees in the environment (so project-level build and test execution were not possible).
Attempted to compile the new test source but compilation failed in this environment because gtest/gtest.h is not available, so the added GTests were not executed here.
The new tests assert ApplySample vs direct-mutation equivalence for publisher ingestion, process cascade deletion behavior, and current/previous revision tracking and are included for CI to run when third-party/test dependencies are available.

Codex Task

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 25. Check the log or trigger a new build to see more.

github-actions · 2026-02-20T14:29:28Z

+#include <utility>
+
+namespace eCAL
+{


warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]

Suggested change

{

ecal/core/src/registration/ecal_registration_database.cpp:25:

- namespace Registration + namespace eCAL::Registration

ecal/core/src/registration/ecal_registration_database.cpp:450:

- }

github-actions · 2026-02-20T14:29:28Z

+      return ApplyMutation([key_, &delta_](State& state_, std::vector<EntityEvent>&, bool& changed_)
+      {
+        auto it = state_.process_monitoring.find(key_);
+        if (it == state_.process_monitoring.end() || !(it->second.state == delta_.state && it->second.time_sync_state == delta_.time_sync_state))


warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]

Suggested change

if (it == state_.process_monitoring.end() || !(it->second.state == delta_.state && it->second.time_sync_state == delta_.time_sync_state))

if (it == state_.process_monitoring.end() || !it->second.state == delta_.state || it->second.time_sync_state != delta_.time_sync_state)

github-actions · 2026-02-20T14:29:28Z

+      auto it = state_.REG_MAP.find(key_); if (it != state_.REG_MAP.end()) { RemoveMembership(state_.members_by_process, it->second.process_id, EntityType::TYPE_ENUM, key_); state_.REG_MAP.erase(it); state_.MON_MAP.erase(key_); events_.push_back({ EventType::deleted_entity, EntityType::TYPE_ENUM, key_ }); changed_ = true; } \
+    }); }
+
+    ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC(Publisher, publisher, publishers, publisher_monitoring)


warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]

ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC(Publisher, publisher, publishers, publisher_monitoring) ^

Additional context

ecal/core/src/registration/ecal_registration_database.cpp:237: expanded from macro 'ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC'

else if (!(it->second.topic == delta_.topic && it->second.process_id == delta_.process_id && it->second.host_name == delta_.host_name)) { \ ^

github-actions · 2026-02-20T14:29:28Z

+    }); }
+
+    ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC(Publisher, publisher, publishers, publisher_monitoring)
+    ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC(Subscriber, subscriber, subscribers, subscriber_monitoring)


warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]

ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC(Subscriber, subscriber, subscribers, subscriber_monitoring) ^

Additional context

ecal/core/src/registration/ecal_registration_database.cpp:237: expanded from macro 'ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC'

else if (!(it->second.topic == delta_.topic && it->second.process_id == delta_.process_id && it->second.host_name == delta_.host_name)) { \ ^

github-actions · 2026-02-20T14:29:28Z

+          events_.push_back({ EventType::new_entity, EntityType::server, key_ });
+          changed_ = true;
+        }
+        else if (!(it->second.service == delta_.service && it->second.process_id == delta_.process_id && it->second.host_name == delta_.host_name))


warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]

Suggested change

else if (!(it->second.service == delta_.service && it->second.process_id == delta_.process_id && it->second.host_name == delta_.host_name))

else if (!it->second.service == delta_.service || it->second.process_id != delta_.process_id || !it->second.host_name == delta_.host_name)

github-actions · 2026-02-20T14:29:29Z

+        bool HasSubscriber(EntityKey key) const;
+        bool HasServer(EntityKey key) const;
+        bool HasClient(EntityKey key) const;
+        size_t ProcessCount() const;


warning: function 'ProcessCount' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

size_t ProcessCount() const;

[[nodiscard]] size_t ProcessCount() const;

github-actions · 2026-02-20T14:29:29Z

+        bool HasServer(EntityKey key) const;
+        bool HasClient(EntityKey key) const;
+        size_t ProcessCount() const;
+        size_t PublisherCount() const;


warning: function 'PublisherCount' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

size_t PublisherCount() const;

[[nodiscard]] size_t PublisherCount() const;

github-actions · 2026-02-20T14:29:29Z

+        bool HasClient(EntityKey key) const;
+        size_t ProcessCount() const;
+        size_t PublisherCount() const;
+        size_t SubscriberCount() const;


warning: function 'SubscriberCount' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

size_t SubscriberCount() const;

[[nodiscard]] size_t SubscriberCount() const;

github-actions · 2026-02-20T14:29:29Z

+        size_t ProcessCount() const;
+        size_t PublisherCount() const;
+        size_t SubscriberCount() const;
+        size_t ServerCount() const;


warning: function 'ServerCount' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

size_t ServerCount() const;

[[nodiscard]] size_t ServerCount() const;

github-actions · 2026-02-20T14:29:29Z

+        size_t PublisherCount() const;
+        size_t SubscriberCount() const;
+        size_t ServerCount() const;
+        size_t ClientCount() const;


warning: function 'ClientCount' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

size_t ClientCount() const;

[[nodiscard]] size_t ClientCount() const;

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 25. Check the log or trigger a new build to see more.

github-actions · 2026-02-20T14:29:39Z

+#include <utility>
+
+namespace eCAL
+{


warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]

Suggested change

{

ecal/core/src/registration/ecal_registration_database.cpp:25:

- namespace Registration + namespace eCAL::Registration

ecal/core/src/registration/ecal_registration_database.cpp:450:

- }

github-actions · 2026-02-20T14:29:39Z

+      return ApplyMutation([key_, &delta_](State& state_, std::vector<EntityEvent>&, bool& changed_)
+      {
+        auto it = state_.process_monitoring.find(key_);
+        if (it == state_.process_monitoring.end() || !(it->second.state == delta_.state && it->second.time_sync_state == delta_.time_sync_state))


warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]

Suggested change

if (it == state_.process_monitoring.end() || !(it->second.state == delta_.state && it->second.time_sync_state == delta_.time_sync_state))

if (it == state_.process_monitoring.end() || !it->second.state == delta_.state || it->second.time_sync_state != delta_.time_sync_state)

github-actions · 2026-02-20T14:29:39Z

+      auto it = state_.REG_MAP.find(key_); if (it != state_.REG_MAP.end()) { RemoveMembership(state_.members_by_process, it->second.process_id, EntityType::TYPE_ENUM, key_); state_.REG_MAP.erase(it); state_.MON_MAP.erase(key_); events_.push_back({ EventType::deleted_entity, EntityType::TYPE_ENUM, key_ }); changed_ = true; } \
+    }); }
+
+    ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC(Publisher, publisher, publishers, publisher_monitoring)


warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]

ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC(Publisher, publisher, publishers, publisher_monitoring) ^

Additional context

ecal/core/src/registration/ecal_registration_database.cpp:237: expanded from macro 'ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC'

else if (!(it->second.topic == delta_.topic && it->second.process_id == delta_.process_id && it->second.host_name == delta_.host_name)) { \ ^

github-actions · 2026-02-20T14:29:39Z

+    }); }
+
+    ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC(Publisher, publisher, publishers, publisher_monitoring)
+    ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC(Subscriber, subscriber, subscribers, subscriber_monitoring)


warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]

ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC(Subscriber, subscriber, subscribers, subscriber_monitoring) ^

Additional context

ecal/core/src/registration/ecal_registration_database.cpp:237: expanded from macro 'ECAL_REGDB_ADD_UPDATE_REMOVE_TOPIC'

else if (!(it->second.topic == delta_.topic && it->second.process_id == delta_.process_id && it->second.host_name == delta_.host_name)) { \ ^

github-actions · 2026-02-20T14:29:39Z

+          events_.push_back({ EventType::new_entity, EntityType::server, key_ });
+          changed_ = true;
+        }
+        else if (!(it->second.service == delta_.service && it->second.process_id == delta_.process_id && it->second.host_name == delta_.host_name))


warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]

Suggested change

else if (!(it->second.service == delta_.service && it->second.process_id == delta_.process_id && it->second.host_name == delta_.host_name))

else if (!it->second.service == delta_.service || it->second.process_id != delta_.process_id || !it->second.host_name == delta_.host_name)

github-actions · 2026-02-20T14:29:40Z

+        bool HasSubscriber(EntityKey key) const;
+        bool HasServer(EntityKey key) const;
+        bool HasClient(EntityKey key) const;
+        size_t ProcessCount() const;


warning: function 'ProcessCount' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

size_t ProcessCount() const;

[[nodiscard]] size_t ProcessCount() const;

github-actions · 2026-02-20T14:29:40Z

+        bool HasServer(EntityKey key) const;
+        bool HasClient(EntityKey key) const;
+        size_t ProcessCount() const;
+        size_t PublisherCount() const;


warning: function 'PublisherCount' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

size_t PublisherCount() const;

[[nodiscard]] size_t PublisherCount() const;

github-actions · 2026-02-20T14:29:40Z

+        bool HasClient(EntityKey key) const;
+        size_t ProcessCount() const;
+        size_t PublisherCount() const;
+        size_t SubscriberCount() const;


warning: function 'SubscriberCount' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

size_t SubscriberCount() const;

[[nodiscard]] size_t SubscriberCount() const;

github-actions · 2026-02-20T14:29:40Z

+        size_t ProcessCount() const;
+        size_t PublisherCount() const;
+        size_t SubscriberCount() const;
+        size_t ServerCount() const;


warning: function 'ServerCount' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

size_t ServerCount() const;

[[nodiscard]] size_t ServerCount() const;

github-actions · 2026-02-20T14:29:40Z

+        size_t PublisherCount() const;
+        size_t SubscriberCount() const;
+        size_t ServerCount() const;
+        size_t ClientCount() const;


warning: function 'ClientCount' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

size_t ClientCount() const;

[[nodiscard]] size_t ClientCount() const;

Add first registration database increment with tests

b0da31b

KerstinKeller added the codex label Feb 20, 2026 — with ChatGPT Codex Connector

github-actions Bot reviewed Feb 20, 2026

View reviewed changes

KerstinKeller added 2 commits February 23, 2026 12:29

Add diff and query APIs to registration database

0e9b89b

Refine registration DB API for snapshot-centric querying

1ba159e

	if (it == state_.process_monitoring.end() \|\| !(it->second.state == delta_.state && it->second.time_sync_state == delta_.time_sync_state))
	if (it == state_.process_monitoring.end() \|\| !it->second.state == delta_.state \|\| it->second.time_sync_state != delta_.time_sync_state)

	else if (!(it->second.service == delta_.service && it->second.process_id == delta_.process_id && it->second.host_name == delta_.host_name))
	else if (!it->second.service == delta_.service \|\| it->second.process_id != delta_.process_id \|\| !it->second.host_name == delta_.host_name)

	size_t ProcessCount() const;
	[[nodiscard]] size_t ProcessCount() const;

	size_t PublisherCount() const;
	[[nodiscard]] size_t PublisherCount() const;

	size_t SubscriberCount() const;
	[[nodiscard]] size_t SubscriberCount() const;

	size_t ServerCount() const;
	[[nodiscard]] size_t ServerCount() const;

	size_t ClientCount() const;
	[[nodiscard]] size_t ClientCount() const;

Conversation

KerstinKeller commented Feb 20, 2026

Motivation

Description

Testing

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant