Skip to content

Fix completeness check #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unp1 merged 1 commit into from
Oct 2, 2026
Merged

Fix completeness check #3990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions key.core/src/main/java/de/uka/ilkd/key/control/AbstractProofControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ private ImmutableList<TacletApp> filterTaclet(Goal focusedGoal,
public boolean selectedTaclet(Taclet taclet, Goal goal,
PosInOccurrence pos) {
ImmutableSet<TacletApp> applics = getAppsForName(goal, taclet.name().toString(), pos);
if (applics.size() == 0) {
if (applics.isEmpty()) {
return false;
}
return selectedTaclet(applics, goal);
Expand All @@ -207,7 +207,7 @@ public boolean selectedTaclet(ImmutableSet<TacletApp> applics, Goal goal) {
if (applics.size() == 1) {
TacletApp firstApp = it.next();
boolean ifSeqInteraction = !firstApp.taclet().assumesSequent().isEmpty();
if (isMinimizeInteraction() && !firstApp.complete()) {
if (isMinimizeInteraction() && !firstApp.completeExceptSkolemConstants()) {
ImmutableList<TacletApp> ifSeqCandidates =
firstApp.findIfFormulaInstantiations(goal.sequent(), services);

Expand All @@ -229,7 +229,8 @@ public boolean selectedTaclet(ImmutableSet<TacletApp> applics, Goal goal) {
}

}
if (ifSeqInteraction || !firstApp.complete()) {
if (ifSeqInteraction || !firstApp.completeExceptSkolemConstants() ||
(!isMinimizeInteraction() && !firstApp.complete())) {
LinkedList<TacletApp> l = new LinkedList<>();
l.add(firstApp);
TacletInstantiationModel[] models = completeAndApplyApp(l, goal);
Expand Down
Loading