Adding set course functionality#93
Draft
savagewil wants to merge 2 commits into
Draft
Conversation
Added documentation explaining usability with new courses.
Collaborator
|
This looks super handy! Thank you! Is it still a draft, or am I free to get this merged in? |
|
Tested and it looks like it works fine to me. I'd suggest merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although
_set_languagealready exists in the library, it is limited and not public-facing.The new set_course function allows the user to change to any language course, including those taught in other languages.
I have added documentation to show how the function is used.