Added cull mode and front face using dynamic mode extension, to avoid additional binding

Author: KabalMcBlade

VesperEngine/Backend/device.cpp

@@ -16,6 +16,9 @@
 
 VESPERENGINE_NAMESPACE_BEGIN
 
+PFN_vkCmdSetCullModeEXT  vkCmdSetCullModeEXT = nullptr;
+PFN_vkCmdSetFrontFaceEXT vkCmdSetFrontFaceEXT = nullptr;
+
 // local callback functions
 static VKAPI_ATTR VkBool32 VKAPI_CALL DebugCallback(
 	VkDebugUtilsMessageSeverityFlagBitsEXT _messageSeverity,
@@ -198,7 +201,12 @@ void Device::CreateLogicalDevice()
 	VkPhysicalDeviceFeatures deviceFeatures = {};
 	deviceFeatures.samplerAnisotropy = VK_TRUE;
 
-	// EXT features
+	// EXT features -> Dynamic state
+	VkPhysicalDeviceExtendedDynamicStateFeaturesEXT dynamicStateFeatures = {};
+	dynamicStateFeatures.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_EXTENDED_DYNAMIC_STATE_FEATURES_EXT;
+	dynamicStateFeatures.extendedDynamicState = VK_TRUE;
+
+	// EXT features -> Indexing
 	VkPhysicalDeviceDescriptorIndexingFeaturesEXT indexingFeatures = {};
 	indexingFeatures.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES_EXT;
 	indexingFeatures.runtimeDescriptorArray = VK_TRUE;
@@ -212,13 +220,19 @@ void Device::CreateLogicalDevice()
 // 	indexingFeatures.descriptorBindingUniformTexelBufferUpdateAfterBind = VK_TRUE;
 // 	indexingFeatures.descriptorBindingStorageTexelBufferUpdateAfterBind = VK_TRUE; 	
 
+
 	VkPhysicalDeviceFeatures2 deviceFeatures2 = {};
 	deviceFeatures2.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
 	deviceFeatures2.features = deviceFeatures;  // Include base features like samplerAnisotropy
 
 	if (m_bIsBindlessResourcesSupported)
 	{
-		deviceFeatures2.pNext = &indexingFeatures;
+		dynamicStateFeatures.pNext = &indexingFeatures;
+		deviceFeatures2.pNext = &dynamicStateFeatures;
+	}
+	else
+	{
+		dynamicStateFeatures.pNext = &indexingFeatures;
 	}
 
 	VkDeviceCreateInfo createInfo = {};
@@ -243,7 +257,16 @@ void Device::CreateLogicalDevice()
 
 	// Use features2 instead of pEnabledFeatures
 	createInfo.pEnabledFeatures = nullptr;
-	createInfo.pNext = &deviceFeatures2;
+
+	if (m_bIsBindlessResourcesSupported)
+	{
+		createInfo.pNext = &deviceFeatures2;
+	}
+	else
+	{
+		createInfo.pNext = &dynamicStateFeatures;;
+	}
+	//
 
 	if (vkCreateDevice(m_physicalDevice, &createInfo, nullptr, &m_device) != VK_SUCCESS)
 	{
@@ -252,6 +275,22 @@ void Device::CreateLogicalDevice()
 
 	vkGetDeviceQueue(m_device, indices.GraphicsFamily, 0, &m_graphicsQueue);
 	vkGetDeviceQueue(m_device, indices.PresentFamily, 0, &m_presentQueue);
+
+	if (VK_EXT_extended_dynamic_state2_enabled)
+	{
+		// the function name vkCmdSetCullMode does not have EXT vkCmdSetCullModeEXT, because in Vulkan 1.3 they were promoted to Core
+		vkCmdSetCullModeEXT = reinterpret_cast<PFN_vkCmdSetCullModeEXT>(vkGetDeviceProcAddr(m_device, "vkCmdSetCullMode"));
+		vkCmdSetFrontFaceEXT = reinterpret_cast<PFN_vkCmdSetFrontFaceEXT>(vkGetDeviceProcAddr(m_device, "vkCmdSetFrontFace"));
+
+		if (!vkCmdSetCullModeEXT || !vkCmdSetFrontFaceEXT)
+		{
+			throw std::runtime_error("failed to create logical device! Device does not support VK_EXT_extended_dynamic_state2, which is required!");
+		}
+	}
+	else
+	{
+		throw std::runtime_error("failed to create logical device! Device does not support VK_EXT_extended_dynamic_state2, which is required!");
+	}
 }
 
 void Device::CreateCommandPool()
@@ -536,6 +575,10 @@ bool Device::CheckDeviceExtensionSupport(VkPhysicalDevice _device)
 		{
 			VK_EXT_descriptor_indexing_extension_enabled = true;
 		}
+		else if (strcmp(extension.extensionName, VK_EXT_EXTENDED_DYNAMIC_STATE_2_EXTENSION_NAME) == 0)
+		{
+			VK_EXT_extended_dynamic_state2_enabled = true;
+		}
 
 		requiredExtensions.erase(extension.extensionName);
 	}

VesperEngine/Backend/device.h

@@ -31,6 +31,8 @@ struct QueueFamilyIndices
 	bool IsComplete() { return GraphicsFamilyHasValue && PresentFamilyHasValue; }
 };
 
+extern PFN_vkCmdSetCullModeEXT vkCmdSetCullModeEXT;
+extern PFN_vkCmdSetFrontFaceEXT vkCmdSetFrontFaceEXT;
 
 class VESPERENGINE_API Device final
 {
@@ -115,6 +117,7 @@ class VESPERENGINE_API Device final
 	bool VK_EXT_memory_priority_enabled = false;
 	bool VK_EXT_debug_utils_enabled = false;
 	bool VK_EXT_descriptor_indexing_extension_enabled = false;
+	bool VK_EXT_extended_dynamic_state2_enabled = false;
 
 	bool m_bIsBindlessResourcesSupported = false;
 
@@ -162,7 +165,8 @@ class VESPERENGINE_API Device final
 	const std::vector<const char*> m_validationLayers = { "VK_LAYER_KHRONOS_validation" };
 	const std::vector<const char*> m_deviceExtensions = { 
 		VK_KHR_SWAPCHAIN_EXTENSION_NAME,			// Swapchain support
-		VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME	// Bindless binding support
+		VK_EXT_DESCRIPTOR_INDEXING_EXTENSION_NAME,	// Bindless binding support
+		VK_EXT_EXTENDED_DYNAMIC_STATE_2_EXTENSION_NAME  // Extended dynamic state 2
 	};
 };
 

VesperEngine/Backend/model_data.h

@@ -70,6 +70,7 @@ struct MaterialData
 	BufferComponent UniformBuffer;
 	int32 Index{ -1 };
 	bool IsTransparent{ false };
+	bool IsDoubleSided{ false };
 	MaterialType Type;
 };
 
@@ -91,6 +92,7 @@ struct ModelData
 	std::vector<uint32> Indices{};
 	std::shared_ptr<MaterialData> Material;
 	bool IsStatic{ false };
+	bool IsMirrored{ false };
 	glm::vec4 MorphWeights[2]{ glm::vec4(0.0f), glm::vec4(0.0f) };
 	uint32 MorphTargetCount{ 0 };
 	std::vector<MorphAnimation> Animations{};

VesperEngine/Backend/pipeline.cpp

@@ -123,8 +123,14 @@ void Pipeline::DefaultPipelineConfiguration(PipelineConfigInfo& _outConfigInfo)
 		VK_DYNAMIC_STATE_VIEWPORT, 
 
 		// Scissor is like Viewport, but instead "squash" the result image (Viewport.width/height if changed keep the image but squashed), it will cut it.
-	// Any pixels outside of the Scissor rectangle (offset + extent) will be discarded.
-		VK_DYNAMIC_STATE_SCISSOR 
+		// Any pixels outside of the Scissor rectangle (offset + extent) will be discarded.
+		VK_DYNAMIC_STATE_SCISSOR,
+
+		// Allow changing culling mode dynamically
+		VK_DYNAMIC_STATE_CULL_MODE,
+
+		// Allow changing front face dynamically
+		VK_DYNAMIC_STATE_FRONT_FACE
 	};
 	_outConfigInfo.DynamicStateInfo.sType = VK_STRUCTURE_TYPE_PIPELINE_DYNAMIC_STATE_CREATE_INFO;
 	_outConfigInfo.DynamicStateInfo.pDynamicStates = _outConfigInfo.DynamicStateEnables.data();
@@ -326,6 +332,14 @@ void Pipeline::Bind(VkCommandBuffer _commandBuffer)
 {
 	// VK_PIPELINE_BIND_POINT_GRAPHICS signal is a graphic pipeline (other are compute and ray tracing)
 	vkCmdBindPipeline(_commandBuffer, VK_PIPELINE_BIND_POINT_GRAPHICS, m_graphicPipeline);
+
+	// TODO: This break Skybox!
+	// fallback, to avoid validation error, since is expecting culling to be dynamic (for now)
+//	vkCmdSetCullModeEXT(_commandBuffer, VK_CULL_MODE_BACK_BIT);
+//	vkCmdSetFrontFaceEXT(_commandBuffer, VK_FRONT_FACE_COUNTER_CLOCKWISE);
+	//vkCmdSetDepthTestEnableEXT(_commandBuffer, VK_TRUE);          // if depth test is dynamic
+	//vkCmdSetDepthWriteEnableEXT(_commandBuffer, VK_TRUE);         // if write is dynamic
+	//vkCmdSetBlendConstants(_commandBuffer, blendConstants);       // if blending is dynamic
 }
 
 std::vector<int8> Pipeline::ReadFile(const std::string& _filepath)

VesperEngine/Components/graphics_components.h

@@ -60,6 +60,7 @@ struct MaterialComponent
 {
 	using FieldType = int32;
 	int32 Index{ -1 };
+	bool IsDoubleSided{ false };
 
 	// store the descriptor set bound to the resource per presentation frame (1,2 or 3)
 	std::vector<VkDescriptorSet> BoundDescriptorSet;

VesperEngine/Components/object_components.h

@@ -38,6 +38,7 @@ struct StaticComponent
 struct UpdateComponent
 {
 	glm::mat4 ModelMatrix{ 1 };
+	bool IsMirrored{ false };
 };
 
 // define the struct which each instance has at least to have, if needs to be visible

VesperEngine/Systems/brdf_lut_generation_system.cpp

@@ -61,6 +61,12 @@ void BRDFLUTGenerationSystem::Generate(VkCommandBuffer _commandBuffer, uint32 _w
 	const PushResolution resolution{{ _width, _height }};
 	PushConstants(_commandBuffer, 0, &resolution);
 
+	//if (vkCmdSetCullModeEXT && vkCmdSetFrontFaceEXT)  // no need, we do throw and exception if not supported
+	{
+		vkCmdSetCullModeEXT(_commandBuffer, VK_CULL_MODE_NONE);
+		vkCmdSetFrontFaceEXT(_commandBuffer, VK_FRONT_FACE_COUNTER_CLOCKWISE);
+	}
+
 	Bind(m_quadVertexBufferComponent, _commandBuffer);
 	Draw(m_quadVertexBufferComponent, _commandBuffer);
 }

VesperEngine/Systems/irradiance_convolution_generation_system.cpp

@@ -148,6 +148,12 @@ void IrradianceConvolutionGenerationSystem::Generate(
     PushConstant pc{ _viewProj, _deltaPhi, _deltaTheta };
     PushConstants(_commandBuffer, 0, &pc);
 
+    //if (vkCmdSetCullModeEXT && vkCmdSetFrontFaceEXT)  // no need, we do throw and exception if not supported
+    {
+        vkCmdSetCullModeEXT(_commandBuffer, VK_CULL_MODE_NONE);
+        vkCmdSetFrontFaceEXT(_commandBuffer, VK_FRONT_FACE_COUNTER_CLOCKWISE);
+    }
+
     Bind(m_cubeVertex, _commandBuffer);
     Draw(m_cubeVertex, _commandBuffer);
 }

VesperEngine/Systems/material_system.cpp

@@ -34,6 +34,7 @@ const MaterialSystem::DefaultMaterialType MaterialSystem::DefaultPhongMaterial =
 		float{0.5f}
 	},
 	false,
+    false,
 	MaterialType::Phong
 };
 
@@ -49,6 +50,7 @@ std::shared_ptr<MaterialData> MaterialSystem::CreateMaterial(
 	const std::vector<std::string>& _texturePaths,
 	const std::vector<std::any>& _values,
 	bool _bIsTransparent,
+    bool _bIsDoubleSided,
 	MaterialType _type,
     const std::vector<int32>& _uvIndices)
 {
@@ -65,6 +67,7 @@ std::shared_ptr<MaterialData> MaterialSystem::CreateMaterial(
 
 	material->Type = _type;
 	material->IsTransparent = _bIsTransparent;
+    material->IsDoubleSided = _bIsDoubleSided;
 
 #ifdef _DEBUG
 	material->Name = _name;
@@ -206,6 +209,7 @@ std::shared_ptr<MaterialData> MaterialSystem::CreateMaterial(
     const std::vector<std::shared_ptr<TextureData>>& _textures,
     const std::vector<std::any>& _values,
     bool _bIsTransparent,
+    bool _bIsDoubleSided,
     MaterialType _type,
     const std::vector<int32>& _uvIndices)
 {
@@ -222,6 +226,7 @@ std::shared_ptr<MaterialData> MaterialSystem::CreateMaterial(
 
     material->Type = _type;
     material->IsTransparent = _bIsTransparent;
+    material->IsDoubleSided = _bIsDoubleSided;
 
 #ifdef _DEBUG
     material->Name = _name;
@@ -356,7 +361,7 @@ std::shared_ptr<MaterialData> MaterialSystem::CreateMaterial(
 
 std::shared_ptr<MaterialData> MaterialSystem::CreateMaterial(const DefaultMaterialType& _defaultMaterial)
 {
-	return CreateMaterial(_defaultMaterial.Name, _defaultMaterial.Textures, _defaultMaterial.Values, _defaultMaterial.IsTransparent, _defaultMaterial.Type, {});
+	return CreateMaterial(_defaultMaterial.Name, _defaultMaterial.Textures, _defaultMaterial.Values, _defaultMaterial.IsTransparent, _defaultMaterial.IsDoubleSided, _defaultMaterial.Type, {});
 }
 
 void MaterialSystem::Cleanup()

VesperEngine/Systems/material_system.h

@@ -75,6 +75,7 @@ class VESPERENGINE_API MaterialSystem final
 		const std::vector<std::string>& Textures;
 		const std::vector<std::any> Values;
 		bool IsTransparent;
+		bool IsDoubleSided;
 		MaterialType Type;
 	};
 
@@ -96,6 +97,7 @@ class VESPERENGINE_API MaterialSystem final
 		const std::vector<std::string>& _texturePaths,
 		const std::vector<std::any>& _values,
 		bool _bIsTransparent,
+		bool _bIsDoubleSided,
 		MaterialType _type,
 		const std::vector<int32>& _uvIndices = {});
 
@@ -107,6 +109,7 @@ class VESPERENGINE_API MaterialSystem final
 		const std::vector<std::shared_ptr<TextureData>>& _textures,
 		const std::vector<std::any>& _values,
 		bool _bIsTransparent,
+		bool _bIsDoubleSided,
 		MaterialType _type,
 		const std::vector<int32>& _uvIndices = {});