[REFACTOR] Navigation Structure/Logic Improvement#99
Merged
doyoonkim3312 merged 5 commits intoMar 30, 2026
Conversation
* Improve navigation structure/logic for the navigation via BottomNavBar.
- Apply Nested-Navigation graph for increased scalability, encapsulation of related screens, and better BackStackEntry Management.
- For the robust navigation handling for destinations accessed via BottomNavBar, Each BottomNavBar triggers the navigation to the corresponding NavGraph, with appropriate nav configuration (Save states for related instances, and restore it on later visit; Prevent multiple instantiation of same object per every screen visit)
- Implement Custom-defined BottomNavigationState composable to perform chronological back-button action handling.
- Refactor category-specific NavDestination into one, generalized NavDestination that accepts the category as a parameter.
* Improve navigation structure/logic for the navigation via BottomNavBar.
- Modify Lifecycle-bind event triggering logic to respect both Composition Lifecycle and Activity Lifecycle.
- Define Custom OnForegroundFocusEffect to seamlessly respond to both Composition and Activity Lifecycle.
(Instant event triggering on Screen becomes initially visible (Composition Lifecycle), LifecycleObserver to trigger event based on Application/Activity Lifecycle.
* Improve navigation structure/logic for the navigation via BottomNavBar.
- Remove unused import directives
- Completion of 1.7.1 Epic. Build configuration has been updated.
* Version Code: 38
* Version Name: 1.7.1 RC 1
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the navigation architecture by introducing nested navigation graphs and a custom BottomNavigationState to manage tab history and back-stack synchronization. It also implements an OnForegroundFocusEffect utility to handle lifecycle-aware UI events across several feature screens, including Home, Bookmark, and Major Notices. Review feedback highlights a potential state inconsistency in the preference navigation logic and suggests refactoring duplicated navigation code for better maintainability.
β¦ed NavGraph to perform navigation - Replace navigation via direct navController access to dedicated navigation function performs navigation via BottomNavState to ensure SSOT - Implement separate NavRoute resolver to resolve corresponding NavDestination for NoticeDetail and BookmarkDetail/Edit.
Member
Author
|
/gemini summary |
Summary of ChangesThis pull request refactors the application's navigation architecture to mitigate memory risks and improve resource efficiency. By transitioning to a nested navigation graph structure and implementing custom state management for the bottom navigation bar, the changes ensure more deterministic behavior and reduced object allocations. Additionally, new lifecycle-aware effects were introduced to standardize how data is refreshed when screens regain focus. Highlights
Activity
|
jeongHunE
approved these changes
Mar 30, 2026
doyoonkim3312
deleted the
REFACTOR/1.7.1/navigation-structure-improvement
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Summary (κ°μ)
π Related Issue (κ΄λ ¨ μ΄μ)
π Type of Change (λ³κ²½ μ¬ν)
FEAT: New feature (μλ‘μ΄ κΈ°λ₯)FIX: Bug fix (λ²κ·Έ μμ )REFACTOR: Code refactoring (no functional change) (μ½λ 리ν©ν λ§)DESIGN: UI/UX changes (λμμΈ λ³κ²½)!HOTFIX: Critical fix (μΉλͺ μ μΈ λ²κ·Έ μμ )CHORE: Build/Config/CI (λΉλ/μ€μ /CI)β¨ Key Changes (ν΅μ¬ λ³κ²½ μ¬ν)
saveState/restoreStateandlaunchSingleTopoptions.BottomBarStateobject to achieve chronological back-action handling throughout the navigation.OnForegroudFocusEffectto achieve robust management of Lifecycle Event-bind event triggering, respecting both Composition Lifecycle and Application/Activity Lifecycle.π§ͺ Test Plan (ν μ€νΈ κ³ν)
π Quantitative Analysis (μ λλΆμ)
Method
HomeDashboardandNoticeByMajorusing BottomNavBar, 10 timesResult
HomeViewModelActive InstancesNoticeByMajorViewModelActive Instancesβ Checklist (체ν¬λ¦¬μ€νΈ)