[!HOTFIX] Fatal Issue Mitigation#103
Merged
Merged
Conversation
* Fatal issues reported from 1.7.1 artifact are resolved.
- LifecycleAwareAndroidView
* Include Fallback logic and Fallback screen for situations where Context is not resolved or WebView/Chromium engine is not available.
* Add Context resolving logic to find Context instance in ContextWrapper is provided via LocalComposition.
- TokenHandler (Firebase)
* Add exception handling logic to mitigate the situation where Firebase Service is unavailable on User's device.
* Add appropriate validation logic to let PeriodicWork can retry the task later when FirebaseService becomes available.
* Fatal issues reported from 1.7.1 artifact are resolved.
- Necessary String Resource for new fallback placeholder screen.
- Update Build Configuration
* Version Code: 41
* Version Name: 1.7.2
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increments the application version and introduces robust error handling for Firebase token retrieval and WebView initialization. Key changes include the addition of a getToken helper in TokenHandler.kt to handle IPC failures and the implementation of a fallback PlaceholderScreen in LifecycleAwareWebView for scenarios where the WebView engine is missing or the activity context is unavailable. The review feedback focuses on best practices for coroutine exception handling, optimizing context lookups using remember, and improving logging by including full stack traces.
- Apply recommended changes provided by Gemini CodeReview
* Rethrow CancellationException to ensure structured concurrency
* Let Compose remember the retrieved context value for efficiency.
jeongHunE
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Summary (κ°μ)
π Related Issue (κ΄λ ¨ μ΄μ)
π Type of Change (λ³κ²½ μ¬ν)
FEAT: New feature (μλ‘μ΄ κΈ°λ₯)FIX: Bug fix (λ²κ·Έ μμ )REFACTOR: Code refactoring (no functional change) (μ½λ 리ν©ν λ§)DESIGN: UI/UX changes (λμμΈ λ³κ²½)!HOTFIX: Critical fix (μΉλͺ μ μΈ λ²κ·Έ μμ )CHORE: Build/Config/CI (λΉλ/μ€μ /CI)β¨ Key Changes (ν΅μ¬ λ³κ²½ μ¬ν)
LifecycleAwareWebViewcomposable. (Due to both app-level and OS-level issue.)ContextWrapperinstead ofActivitydue to its design pattern. IfContextWrapperis provided, WebView becomes unavailable and throws RuntimeException.TokenHandlerto gracefully handle a potentialIOExceptioncause by Firebase Service (Firebase Service is unavailable on User's device)πΈ Screenshots / Video (μ€ν¬λ¦°μ· λλ λμμ)
π§ͺ Test Plan (ν μ€νΈ κ³ν)
ApplicationContexttoLifecycleAwareWebViewcomposable -> Check Fallback Screen is visible.com.google.android.webviewand Chromecom.android.chrome. -> Check Fallback Screen is visible.β Checklist (체ν¬λ¦¬μ€νΈ)