Refactor/1.7.3/carrel widget modification#102
Merged
doyoonkim3312 merged 6 commits intoApr 7, 2026
Conversation
* Enable Study-Room Widget, starting from 1.7.3 release.
- Revoke WidgetReceiver registration
- Revoke Immediate Widget Update logic, reflecting Process Lifecycle.
- Change method of displaying Carrel Room status metrics on Widget.
- Replace hardcoded string to fully localized string resource (if applicable)
- Before: Display current occupied seat and total seats available. (Occupied Seats / Total Seats)
- After: Display current remaining seats.
- Apply appropriate track color of the Ring graph to be generated by CarrelStatusBitmapGenerator. - Apply New Study Room Status Widget color scheme to Preview Layout and necessary preview Ring Graphs.
- Define Theme-aware Color Resource for Widget Preview. - Define necessary localized String resource.
- Feature Delivered (KAN-103; μ΄λμ€ μμ ―)
- Build configuraiton has been updated.
* Version Code: 41
* Version Name: 1.7.3 alpha-01
doyoonkim3312
added
Improvement
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request re-enables the Carrel Room Status widget, updates the application versioning to 1.7.3 alpha-01, and introduces theme-aware UI components for the widget. The reviewer recommended using localized format strings for seat counts to prevent spacing issues across different languages and noted a filename inconsistency that should be corrected for better maintainability.
- Allow String Resource would take integer as part of the resource definition. (Apply dynamic space between string resource and non-static value combined.) - Change the Filename to match with the defined class name.
jeongHunE
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Summary (κ°μ)
π Related Issue (κ΄λ ¨ μ΄μ)
π Type of Change (λ³κ²½ μ¬ν)
FEAT: New feature (μλ‘μ΄ κΈ°λ₯)FIX: Bug fix (λ²κ·Έ μμ )REFACTOR: Code refactoring (no functional change) (μ½λ 리ν©ν λ§)DESIGN: UI/UX changes (λμμΈ λ³κ²½)!HOTFIX: Critical fix (μΉλͺ μ μΈ λ²κ·Έ μμ )CHORE: Build/Config/CI (λΉλ/μ€μ /CI)β¨ Key Changes (ν΅μ¬ λ³κ²½ μ¬ν)
CarrelRoomWidgetfor upcoming 1.7.3 release. Corresponding WidgetReceiver and Lifecycle (ProcessLifecycle) reflected widget update logic have been revoked.πΈ Screenshots / Video (μ€ν¬λ¦°μ· λλ λμμ)
Light Theme (λΌμ΄νΈ λͺ¨λ)
Dark Theme (λ€ν¬ λͺ¨λ)
π§ͺ Test Plan (ν μ€νΈ κ³ν)
β Checklist (체ν¬λ¦¬μ€νΈ)