Draft
Fix WebInterface node overlap for large arbitration graphs#153
Conversation
Member
|
Please avoid adding more dependencies. |
- Add optionSubtreeHeight() to recursively compute total vertical space needed by each subtree (sum of children's heights, or optionOuterHeight for leaf nodes) - Update optionY() to use cumulative subtree heights instead of uniform per-node spacing, centering each node within its allocated subtree space - Add example_nested_large.yaml with the example from the issue report - Add "Large nested example" link in the UI for testing/demonstration Co-authored-by: orzechow <5220714+orzechow@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix WebInterface overlapping with larger arbitration_graphs
Fix WebInterface node overlap for large arbitration graphs
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The graph layout algorithm used a fixed uniform height per option (
optionOuterHeight = 50px), ignoring the actual vertical space consumed by nested arbitrators. This caused sibling subtrees at the same depth to overlap when children had differing numbers of descendants.Changes
arbitrator_option.js: Replace flat uniform-spacing layout with subtree-aware positioning:optionSubtreeHeight(behavior)— recursively sums children's heights (leaf →optionOuterHeight; arbitrator → sum of children's subtree heights)optionY(index)to accumulate subtree heights and center each node within its allocated space, instead of multiplying by a fixed stepBackward-compatible: flat (leaf-only) trees produce identical positions to the previous algorithm.
example_nested_large.yaml+ UI link: adds the example from the issue report as a loadable demo.Before / After
Large nested graph (from the issue) — nodes no longer overlap:
Existing nested example — unaffected:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.