Update interfaces to follow optimal control formula#123
Merged
Conversation
.cached() now returns an optional shared pointer. Resolve the optional using value(), the use the -> operator to follow the pointer.
Co-authored-by: Piotr Spieker <orzechow@posteo.de>
Use abstract verifier class in core library
Collaborator
Author
Todo ListAbstract verifiers
Include environment model
Tutorial
Linter issuessee #114
Release
|
Collaborator
Author
|
I added #114 to the todo list here as I suppose that it might also include some breaking changes so maybe it's best to merge all that in one go via this branch. |
Support for the previously used syntax was added in later Python version
Running tests from inside the test directory prevent python from recognizing it as a package causing the relative imports to break
Closed
Closed
Follow fc184d0 in the tutorial docs as well
Interface Update Tutorial Docs
orzechow
marked this pull request as ready for review
September 23, 2025 07:34
orzechow
requested review from
ChristophBurger89 and
orzechow
as code owners
September 23, 2025 07:34
orzechow
approved these changes
Sep 23, 2025
orzechow
left a comment
Member
There was a problem hiding this comment.
This is good to go 🚀
We went though this multiple times in the corresponding sub issues/PRs, docs and tutorials have been updated, this PRs description will serve as release description as well as breaking change notice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes!
This improves some interfaces to resolve two issues:
The main intention behind this refactoring is:
We've always wished
getCommand()(the policy of a given behavior) to better follow the optimal control formulawith command$u$ , policy $μ$ , time $t$ and state $x(t)$ .
Thus, we now changed the interfaces of
getCommand(),checkInvocationCondition()etc. to:It does introduce more boiler plate code. But, by passing the environment model via argument, the interface is more explicit now as of which information the decision-making is based on.
Please check the issue and PR for further details:
#116
#123 (comment)
#major
Closes #116