Checking for python version for the open_binary and files calls#373
Open
TedyonGit wants to merge 1 commit into
Open
Checking for python version for the open_binary and files calls#373TedyonGit wants to merge 1 commit into
TedyonGit wants to merge 1 commit into
Conversation
Owner
|
Thanks, I think that there was a reason I didn't implement this, but I can't recall it anymore. |
K0lb3
reviewed
Jun 13, 2026
| def init(): | ||
| with open_binary("UnityPy.resources", "lzma.tpk") as f: | ||
| data = f.read() | ||
| try: |
Owner
There was a problem hiding this comment.
Instead of try/except,
sys.version_info >= (3, 9)
would be a better option
K0lb3
requested changes
Jun 13, 2026
Owner
|
^ tests failed due to a ruff formatting check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just wanted to fix the warning "DeprecationWarning".
So i just added a check for python version. If the python version is >= 3.9, then is going to use files call.
If not, is going to fallback to open_binary.
Is not much, but i hope it helps :D