Consolidate logging and expose it on debug builds#262
Merged
Conversation
Phoenix7351
approved these changes
Jun 4, 2026
twyatt
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the sub-system for all the various non-js logs as "Topaz" and adds them to the debug build log persistence. So we will have the existing
JsMessagelogs for all the Js related stuff, andTopazlogs for all the app native stuff. I am leavingWebViewlogs alone (and not persisted) as they are usually not very useful and crazy noisy.Note
Low Risk
Logging identifiers and debug plist settings only; no runtime behavior beyond aligning EventBus debug logging with existing app config.
Overview
Unifies native OSLog output under the
Topazsubsystem (with per-module categories such asAppModel,BluetoothEngine,EventBus) instead of separate subsystem names per package.Adds
OSLogPreferencesforTopazinInfo.plistso debug builds persistTopazlogs at Debug level with private data enabled, matching the existingJsMessageconfiguration.WebViewlogging is intentionally unchanged.Wires
EventBus(enableDebugLogging: appConfig.enableDebugLogging)when constructing the Bluetooth stack so event-bus debug logs follow the same app debug flag as the engine and virtual keyboard.Reviewed by Cursor Bugbot for commit b8a33c1. Configure here.