Skip to content

Configure samples/sensortag/#1174

Open
twyatt wants to merge 3 commits into
mainfrom
twyatt/senortag
Open

Configure samples/sensortag/#1174
twyatt wants to merge 3 commits into
mainfrom
twyatt/senortag

Conversation

@twyatt

@twyatt twyatt commented Jun 18, 2026

Copy link
Copy Markdown
Member

Configures the SensorTag sample app that was migrated to this repository from sensortag repo (see db8db81).


Note

Low Risk
Changes are mostly Gradle wiring, CI, and documentation; library APIs are untouched aside from dependency alias renames.

Overview
Wires the migrated SensorTag sample into the Kable repo as a Gradle composite build so it shares the root version catalog, wrapper, and local kable-core instead of a separate repo and duplicate Gradle setup.

Build & deps: Root settings.gradle.kts adds includeBuild("samples/sensortag"); the sample uses includeBuild("../.."), symlinks gradlew / gradle to the parent, and drops its own libs.versions.toml, wrapper, and standalone pages workflow. Root gradle/libs.versions.toml gains Compose, Voyager, Krayon, and sample-related libraries; kable modules switch to the renamed kotlinx-coroutines alias and android.kotlin.multiplatform.library plugin id.

CI & docs: New PR workflows SensorTag / Android, iOS, and Web run from samples/sensortag; root GitHub Pages now bundles Dokka plus the wasm browser build under sensortag/. README and sample README point at in-repo paths and https://juullabs.github.io/kable/sensortag.

Reviewed by Cursor Bugbot for commit f1006d0. Configure here.

@twyatt twyatt added skip-changelog Excludes issue/PR from generated release change log. maintenance General maintenance that doesn't effect the public API. labels Jun 18, 2026
cursor[bot]

This comment was marked as outdated.

@twyatt twyatt force-pushed the twyatt/senortag branch from ab1ca31 to 906a931 Compare June 18, 2026 21:35
@twyatt twyatt force-pushed the twyatt/senortag branch from 906a931 to 7c820d2 Compare June 18, 2026 22:24
@twyatt twyatt force-pushed the twyatt/senortag branch 4 times, most recently from c3679a0 to 5866800 Compare June 18, 2026 22:55
@twyatt twyatt force-pushed the twyatt/senortag branch from 5866800 to f1006d0 Compare June 18, 2026 22:57
@twyatt twyatt marked this pull request as ready for review June 18, 2026 22:59
@twyatt twyatt requested a review from a team as a code owner June 18, 2026 22:59
@twyatt twyatt requested review from cedrickcooke and sdonn3 June 18, 2026 22:59
@twyatt

twyatt commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit f1006d0. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance General maintenance that doesn't effect the public API. skip-changelog Excludes issue/PR from generated release change log.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants