Wrap Android connect permission failures#1167
Open
himu-gupta wants to merge 3 commits into
Open
Conversation
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 783b21d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SecurityExceptionfrom AndroidconnectGatt()intoIllegalStateExceptionBLUETOOTH_CONNECTpermissionCloses #1166
Verification
./gradlew :kable-core:lintKotlinAndroidMain :kable-core:lintKotlinAndroidHostTest :kable-core:testAndroidHostTest./gradlew assemble -PsuppressWarnings=true./gradlew -PRELEASE_SIGNING_ENABLED=false publishToMavenLocal./gradlew checkprogressed through Rust, JVM, Android, JS, Wasm, iOS, and macOS verification; local execution stopped only because Xcode lacks the watchOS simulator SDK required bywatchosSimulatorArm64TestNote
Medium Risk
Touches core connect/cancellation paths on Android and in shared peripheral logic; behavior changes for callers that relied on broad IllegalStateException handling in awaitConnect.
Overview
Android
connectGatt()SecurityExceptions (e.g. missingBLUETOOTH_CONNECT) are now turned intoIllegalStateExceptionwith the original exception as cause, and threading is released before the error propagates.awaitConnectno longer treats everyIllegalStateExceptionas a cancelled peripheral. It catchesCancellationExceptionandInactiveScopeExceptionseparately so real connect failures (including the new permission wrapper) surface unchanged, while disconnect/cancel still map to "Cannot connect peripheral that has been cancelled".SharedRepeatableActionthrowsInactiveScopeExceptionwhen the parent scope is inactive instead of usingcheck().Regression tests cover Android connect permission failure and common
awaitConnectbehavior (preservedIllegalStateException, inactive scope, cancelled action).Reviewed by Cursor Bugbot for commit 783b21d. Configure here.