fix: cross-platform build fixes (Linux/macOS/Windows)#10
Merged
Conversation
… includes New tests: - RoomTests: toJson, fromJson, round-trip, empty defaults (5 tests) - RoomRegistryTests: CRUD, addDevice/removeDevice, duplicate rejection, save/load round-trip (13 tests) - ModuleResultTests: alreadyLoaded/notLoaded status codes and messages (3 tests) - NexusConfigTests: defaults, toJson, save/load, loadOrCreate, partial keys (5 tests) - JsonConfigSourceTests: string/int/float/bool parsing, missing file, empty object (6 tests) - SchedulerTests: valid/invalid cron expressions, multiple tasks, tick (4 tests) Also replaces the old placeholder JsonConfigSourceTests. Fixes: - src/rooms/Room.cpp: Rooms/ -> rooms/ - src/rooms/RoomRegistry.cpp: Rooms/ -> rooms/ - includes/Rooms/RoomRegistry.hpp: Rooms/ -> rooms/ - includes/services/RoomService.hpp: Rooms/ -> rooms/
- includes/Rooms/ renamed to includes/rooms/ so the lowercase includes match the actual path on case-sensitive filesystems (Linux) - ModuleResultTests.cpp: add missing #include <nlohmann/json.hpp>
…ilds - CMakeLists.txt: fix wrong src/pathing/ → src/paths/ (caused build failure everywhere since the directory is named paths/, not pathing/) - tests/CMakeLists.txt: lowercase Event/, Result/, Scheduler/ → event/, result/, scheduler/ so ctest works on case-sensitive filesystems (Linux/macOS) - WindowsModuleScanner.hpp: remove duplicate #include <unordered_set> - Dependencies.cmake: strip emoji from status messages (CI log safety) - ServiceHostFactory.cpp: remove leftover Dutch refactor note
… builds Fixes CI failures on ubuntu-gcc, ubuntu-clang, macos-clang and windows-msvc caused by mixed-case include paths (Event/, Logger/, Scheduler/, Task/, pathing/) that only worked on Windows's case-insensitive filesystem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMakeLists.txt: fixsrc/pathing/→src/paths/— the directory was namedpaths/but CMake referenced a non-existentpathing/, breaking the build on all platformstests/CMakeLists.txt: lowercaseEvent/,Result/,Scheduler/→event/,result/,scheduler/— case-sensitive filesystems (Linux/macOS) would fail to find the test filesWindowsModuleScanner.hpp: remove duplicate#include <unordered_set>cmake/Dependencies.cmake: strip emoji frommessage(STATUS ...)calls for CI log safetyServiceHostFactory.cpp: remove leftover Dutch inline refactor noteTest plan
cmake -B build -DNEXUS_BUILD_TESTS=ON && cmake --build buildsucceeds on Linux (GCC)ctest --test-dir buildfinds and runs all test files without casing errors