Skip to content

architecture: review versioned wrestling card observations - #204

Draft
Jumpstile wants to merge 2 commits into
mainfrom
proposal/wrestling-card-v2-review
Draft

Jumpstile wants to merge 2 commits into
mainfrom
proposal/wrestling-card-v2-review

Conversation

@Jumpstile

@Jumpstile Jumpstile commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

Submit a synthetic-only v2 wrestling event/card observation proposal for review. The v2 shape links each card revision to one unchanged v1 event assertion and the existing canonical event truth layer. V1 remains closed. This PR adds no production adapter, v2 consumer, UI behavior, or live-source access.

Related to #191, #29, #30, and #36. No issue is closed by this PR.

Advisory review recommendations (not approval)

An independent technical design review recommends:

Formal architecture acceptance and product-owner disposition remain pending. The Product Owner/Engineering Manager owns scope and acceptance; #191 identifies @Jumpstile in that role. The product owner is assigned this draft PR. No independent architecture reviewer is currently assigned; request assignment through the repository architecture-proposal workflow before acceptance.

Source-access gate

#29 and #191 remain blocked on a permitted AEW access path and written/terms-supported rights for coverage, automated use, fields, cadence/rate limits, quota/cost, caching/retention, attribution/display, and territory. No live source was queried. The proposal stays synthetic-only. The separate local research note was excluded because repository contributor policy prohibits tracking real provider URLs; the canonical source gate is recorded in #29 and #191.

Transfer and governance deltas

The proposal package was copied byte-for-byte from the preserved local checkpoint where unchanged. Five of nine artifacts are hash-identical. Four intentional deltas are isolated: the proposal now points to canonical #29/#191 source-gate records and records independent recommendations/decision route/next slice; the v2 test directly mutates a valid v1 observation with a forbidden card-revision property and proves v1 rejects it; the offline match key uses an explicit example value after Gitleaks flagged the original synthetic token; and the offline proposal schema was formatted to repository Prettier rules after CI identified it. The original checkpoint remains untouched.

Evidence and checks

  • Focused offline Pester set: 18 passed, 0 failed, including the direct v1 closure mutation.
  • After the explicit example-key rename, the affected offline AEW contract tests passed 6/6.
  • Prettier check passed for the CI-flagged offline schema.
  • Exact-head secret-scan: PASS. Quality-gates is running; no full-suite result is claimed yet.
  • The v1 converter/schema/module dependencies are unchanged between the initial tested base and this PR base.
  • No production behavior changed; user-facing documentation is not applicable.
  • ADR 0008 was reviewed. This draft proposes no accepted ADR change.
  • Independent technical recommendations are advisory; formal architecture/security review remains requested.

Next slice after gates

After formal architecture acceptance and source rights, #29 can implement one permitted AEW schedule-window adapter that emits the ordinary v1 event assertion plus one linked v2 card observation per revision for report-only Guide Intelligence, with synthetic offline tests. No #30 consumer or #191 UI work is included in that slice.

@Jumpstile
Jumpstile force-pushed the proposal/wrestling-card-v2-review branch from 9c1fd82 to 4885e67 Compare October 3, 2026 00:56
@Jumpstile

Copy link
Copy Markdown
Owner Author

Independent exact-head engineering/security review

Verdict: PASS — no actionable findings.

Reviewed the complete nine-file diff from base c928666aa2bde9ab92f4ee58edb515fb5ee097f1 to head 8d41d646011a03e592ca60b23cbd705547a0c03d, including relevant v1 compatibility. The v1 schema/converter remain unchanged. No actionable technical findings were identified.

Review process: completed by the configured independent, non-author reviewer role; this PR comment records its result. No GitHub reviewer was assigned, and this is not a formal GitHub approving review.

Separate gates remain: Product Owner / Engineering Manager scope disposition and formal architecture acceptance are pending; AEW source-access and rights gate remains open. This technical PASS does not authorize production implementation, merge, or release. PR remains draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant